Bug 406569 - Elide tab title on the left when displaying full paths
Summary: Elide tab title on the left when displaying full paths
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 18.12.3
Platform: Manjaro Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-15 15:30 UTC by Julius R.
Modified: 2019-05-20 13:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.04.2
Sentry Crash Report:


Attachments
Left aligned tab description... (303.11 KB, image/png)
2019-04-18 21:06 UTC, Julius R.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julius R. 2019-04-15 15:30:39 UTC
Dear Developers, 
first of all: kudos for your efforts to the community! :)

My feature request:
When using multible tabs, the text-align of the folders name is left. This is sth the (evil) windows explorer does better. With large folder structures, the left-aligned text shows the root of the tabs folder. This obscures the name of the folder, which the user is currently looking at. Example: /home/user/documents/private/finances/2019 becomes /home/user/documents/private/... instead if .../documents/private/finances/2019

The text aligment should be right, to keep the focus on the working folder in view. Imagine having these two folders open:
/home/user/documents/private/finances/2019
/home/user/documents/private/finances/2018

There is no way to distinguish them, with left aligned text, which results in two tabs stating:
/home/user/documents/private/... 
/home/user/documents/private/... 

With regards
Comment 1 Nate Graham 2019-04-16 17:48:55 UTC
Sounds like instead, we could just slide left instead of eliding right. But could you attach a screenshot illustrating the problem?
Comment 2 Julius R. 2019-04-18 21:06:40 UTC
Created attachment 119491 [details]
Left aligned tab description...

I am unwilling to believe, no one ever stumbled across this problem? With left aligned text in tabs, there is no way to differentiate between the folders of other open tabs. :)
Comment 3 Nate Graham 2019-04-18 21:12:58 UTC
Ah, you're using the "Show full path in titlebar" option, which has the effect of putting it in the tabs too, since the tabs show the titlebar's title.

Would an acceptable alternative be to make the tabs only show the name of their current directory when using "Show full path in titlebar", rather than the full path?
Comment 4 Julius R. 2019-04-18 23:25:23 UTC
Oh my... I am ashamed, the most important info is missing: That I am using the "show full path in titlebar" option. Sorry!

Yeah, of course, switching to current folder works - I am using this right now. But still, when having the full path enabled, it should be text-align: right :) Just for logical and obvious reasons.

Have a nice weekend.
Comment 5 Julius R. 2019-04-18 23:30:28 UTC
Stop. Stupid me!
I am too tired. We are misleading each other.

I am not talking about the location pane. I am talking about the TABS! The circled path in the tabs!

Think about the following: You have four tabs open. Now you want to drag and drop on file from your current view, to one of the four tabs. I mean, literally, clicking file test.xyz, dragging to a TAB (!) and releasing it right there.

How is a user supposed to know, what folder that tab is? Have a look at the screenshot, it is impossible to tell. We see the root of the tabs folders, but not the folders name of the open tabs! 
The problem is NOT the location bar, it is the abbreviated display of names in the tabs themselves :)

Cheers
Comment 6 Nate Graham 2019-04-19 16:29:58 UTC
Yep, I get it. Here's a patch: https://phabricator.kde.org/D20689
Comment 7 Julius R. 2019-04-20 09:09:52 UTC
Whoa, that was fast. Thank you very much!
Have a nice easter time. :)
Comment 8 Nate Graham 2019-05-20 13:15:01 UTC
Git commit d863dd9ad46b3a291751bcb9d6fd3930c4ea8afb by Nate Graham.
Committed on 20/05/2019 at 13:14.
Pushed by ngraham into branch 'Applications/19.04'.

Elide tab titles left so key information at the end of the string doesn't get cut off

Summary:
Tab Titles currently elide right. Generally the more useful information is at the right
side of the string--even more so when full paths are being used.
FIXED-IN: 19.04.2

Test Plan:
- No change when tab titles don't get elided
- When tabs show the full path and titles are elided, they're now useful: {F6782447}
- When tabs don't show the full path and are elided, they're elided on the other side which seems maybe a tiny bit better, but at least no worse: {F6782448}

Reviewers: #dolphin, #vdg, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: ndavis, elvisangelaccio, kneckermcknacksack, filipf, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D20689

M  +9    -0    src/dolphintabwidget.cpp

https://commits.kde.org/dolphin/d863dd9ad46b3a291751bcb9d6fd3930c4ea8afb