Bug 406526 - Honest Request: Removal of destructive window shortcuts
Summary: Honest Request: Removal of destructive window shortcuts
Status: CLOSED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 406527 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-04-14 11:42 UTC by plane.wander
Modified: 2019-04-16 09:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description plane.wander 2019-04-14 11:42:05 UTC
Currently KWin still supports destructive window shortcuts like "Close window". That's a problem, an admin might have enabled it or changed the default shortcut for all users because it's so obvious to the admin but unexpected to users. Then a user might accidentely close one of its windows and lose data because they used the wrong shortcut. 

Therefore I suggest to remove all destructive shortcuts in KWin in order to make it more user friendly and to have a predictable user interface with explicit and clear destructive actions.

STEPS TO REPRODUCE
1. Change the default shortcut for "Close window" from <Alt><F4> to something like <Ctrl><Shift><Esc>
2. Ask an experience Windows user to open the task manager on Plasma
3. The Windows user might use the shortcut <Ctrl><Shift><Esc>, which opens the task manager on Windows

OBSERVED RESULT
The task manager doesn't open but the currently focused window gets closed and the user might lose data.

EXPECTED RESULT
The window shouldn't close because someone hit the wrong shortcut.
Comment 1 plane.wander 2019-04-14 11:46:21 UTC
*** Bug 406527 has been marked as a duplicate of this bug. ***
Comment 2 Christoph Feck 2019-04-14 12:59:15 UTC
That's probably not a serious wish, but a prank related to bug 321190 comment #2.
Comment 3 plane.wander 2019-04-14 13:56:37 UTC
(In reply to Christoph Feck from comment #2)
> That's probably not a serious wish, but a prank related to bug 321190
> comment #2.

Prank or not doesn't matter, it's the arguments that matter. Those same arguments were already used as a justification to remove similar functionality from KWin before and I'm just trying to be consistent.

Either the arguments make sense, then they should be taken seriously, or they don't then this whish can be ignored, but then other desicions might need to be re-evaluated.
Comment 4 David Edmundson 2019-04-14 14:53:32 UTC
alt+f4 is not an easy to press shortcut.
Comment 5 plane.wander 2019-04-14 15:01:57 UTC
(In reply to David Edmundson from comment #4)
> alt+f4 is not an easy to press shortcut.

That doesn't matter. An admin can change that shortcut to whatever they felt like, e.g. <Super><e>, <Ctrl><Shift><Esc>, ... which all do non-destructive actions on other platforms, therefore users might accidentally trigger destructive actions on KWin because they expected something else to happen for those shortcuts. Therefore this feature needs to be removed - it's not explicit/clear and might lead to data loss.
Comment 6 David Edmundson 2019-04-14 15:07:01 UTC
Has this been an observed problem?
Comment 7 plane.wander 2019-04-14 15:21:09 UTC
(In reply to David Edmundson from comment #6)
> Has this been an observed problem?

Yes, like I said it can be easily reproduced.
Comment 8 David Edmundson 2019-04-14 15:26:39 UTC
That's not what I meant, I meant if you've observed users accidentally closing windows this way
Comment 9 plane.wander 2019-04-14 15:41:37 UTC
(In reply to David Edmundson from comment #8)
> That's not what I meant, I meant if you've observed users accidentally
> closing windows this way

I don't think my answer to that question should matter given that I could easily lie and there would be no way to prove me wrong. But for the sake of the argument I'll say: Yes, I observed it many times that users lost some data this way.

Imho the important question is if the arguments make sense and given that those same arguments were used to remove similar features in KWin before I thought that they indeed do make sense to the project's goals.
Comment 10 David Edmundson 2019-04-14 17:02:16 UTC
>I could easily lie

It would take a very odd sort of person to be disingenuous on a bug tracker.

However, it seems cfecks initial comments were right.
Thanks for wasting my time.
Comment 11 plane.wander 2019-04-14 17:48:26 UTC
(In reply to David Edmundson from comment #10)
> >I could easily lie
> 
> It would take a very odd sort of person to be disingenuous on a bug tracker.

Then you can assume I'm telling the truth, but I don't know why an anecdote of a single user should have any relevance whatsoever. Like does it make a difference if I witnessed this issue 5 times, or 10 times? And how often is enough for this to become important? Also the last time the same arguments were used to justify the removal of similar features in KWin it didn't matter if it actually happened to anyone.

> However, it seems cfecks initial comments were right.
> Thanks for wasting my time.

I didn't make this personal, I didn't make this OT, I didn't break any Code of Conduct, all I did was putting forward arguments why destructive window shortcuts are an issue in my oppinion. But instead of arguing about the issue, which I'd much rather do, I have to deal with ad hominem attacks.
Comment 12 plane.wander 2019-04-14 21:48:11 UTC
Is this standard procedure here that bug reports are closed without any reason given? I mean its stupid enough that people seem to care more about figuring out my motives and questioning them, which btw. is a violation to your code of conduct, than talking about my arguments, but its even worse if the request is just dismissed without any comment.
Comment 13 Christoph Feck 2019-04-14 22:57:13 UTC
That's not standard procedure. If you have an honest issue, report it.
Comment 14 plane.wander 2019-04-15 04:28:56 UTC
(In reply to Christoph Feck from comment #13)
> That's not standard procedure. If you have an honest issue, report it.

The very first thing you did was assuming bad faith, which goes against your code of conduct. You have absolutely no idea about any of my motives, because you can't possibly know and shouldn't even care. But since you already made up your mind that this isn't honest, despite me giving valid arguments that could be discussed, you're effectively blocking me from participating. I hereby remind you again about the code of conduct both you and me are supposed to follow and ask you to get back on topic.