Bug 406481 - Sidebar text gets elided for most window sizes
Summary: Sidebar text gets elided for most window sizes
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-12 16:03 UTC by Nate Graham
Modified: 2019-04-16 16:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Elided sidebar text (49.42 KB, image/png)
2019-04-12 16:03 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-04-12 16:03:04 UTC
Created attachment 119384 [details]
Elided sidebar text

Elisa from git master.

Sidebar items' text gets elided for window sizes any smaller than being maximized. See attached screenshot. In English, this affects "Recently Played" and "Frequently Playing", and I imagine the problem is even worse in languages where test is generally longer.

It seems like there are two problems here:
1. The sidebar dynamically resizes itself according to the window width instead of being a fixed size according to the length of the longest string
2. Sidebar items' text is really large, exacerbating problem #1.
Comment 1 Matthieu Gallien 2019-04-15 05:50:25 UTC
Thanks for your report.
Comment 2 Nate Graham 2019-04-15 15:26:01 UTC
I'm working on this FWIW. Here's a patch: https://phabricator.kde.org/D20577
Comment 3 Nate Graham 2019-04-16 16:12:13 UTC
Git commit debeff777c3c99293ff30be9872d7b8d00fa580b by Nate Graham.
Committed on 16/04/2019 at 16:12.
Pushed by ngraham into branch 'master'.

Don't adjust the sidebar size with the window size, and reduce the text size a bit

Summary:
Currently the sidebar text is huge and the sidebar itself adjusts its width with
the window's own width. This results in sidebar items' text getting elided with
most window sizes.

This patch reduces the text size a bit and fixes the size, resolving both problems.

Test Plan: {F6774559, size=full}

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Subscribers: filipf

Differential Revision: https://phabricator.kde.org/D20577

M  +1    -1    src/qml/BaseTheme.qml
M  +0    -3    src/qml/ContentView.qml
M  +5    -6    src/qml/ViewSelector.qml

https://commits.kde.org/elisa/debeff777c3c99293ff30be9872d7b8d00fa580b