Bug 406480 - Song names in playlist are elided even when there's plenty of space available
Summary: Song names in playlist are elided even when there's plenty of space available
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-12 15:56 UTC by Nate Graham
Modified: 2019-04-13 21:32 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Elided song names when there'e plenty of space (132.89 KB, image/png)
2019-04-12 15:56 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-04-12 15:56:44 UTC
Created attachment 119383 [details]
Elided song names when there'e plenty of space

Elisa from git master, though I tried https://phabricator.kde.org/D18679 and it made no difference.

Song names in the playlist get elided even when there's plenty of horizontal space available. See attached screenshot.
Comment 1 Nate Graham 2019-04-13 15:52:37 UTC
Patch: https://phabricator.kde.org/D20511
Comment 2 Nate Graham 2019-04-13 21:32:32 UTC
Git commit 358086c2228945e84d0d60a1c94694ec8c3b1bbc by Nate Graham.
Committed on 13/04/2019 at 21:31.
Pushed by ngraham into branch 'master'.

When not displaying rating, leave more room for song title in playlist

Summary:
Currently the Playlist's ratings widget reserves space for itself for unrated songs,
 which causes song titles to get elided even when there's plenty of space.

This patch hides the ratings widget for unrated songs, allowing the song title label
to have more space and not be elides as often.

This could become a problem in the future if there is ever a desire to set ratings
interactively by clicking on the ratings widget, but that's not implemented so for now
there's no issue (and probably a hover-based UI could make sense for that anyway).

Test Plan:
Now song titles for unrated songs have plenty of space, and rated songs display the same:

{F6770576}

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Differential Revision: https://phabricator.kde.org/D20511

M  +2    -0    src/qml/PlayListEntry.qml

https://commits.kde.org/elisa/358086c2228945e84d0d60a1c94694ec8c3b1bbc