Bug 406376 - Falkon KDE Frameworks Integration: KCrash support not working
Summary: Falkon KDE Frameworks Integration: KCrash support not working
Status: REOPENED
Alias: None
Product: Falkon
Classification: Applications
Component: extensions (show other bugs)
Version: 3.1.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-09 19:57 UTC by Kevin Kofler
Modified: 2020-11-10 00:47 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kofler 2019-04-09 19:57:15 UTC
SUMMARY
The Falkon KDE Frameworks Integration extension is linked to KCrash and attempts to initialize it, but crashes are not actually intercepted by it.

STEPS TO REPRODUCE
1. Start Falkon.
2. Simulate a crash: killall -SIGABRT falkon

OBSERVED RESULT
Falkon exits without spawning DrKonqi, but KCrash is configured to do just that on this system.

EXPECTED RESULT
DrKonqi comes up with the crash intercepted by KCrash.

SOFTWARE/OS VERSIONS
Fedora 28 with updates
Falkon 3.1.0
KDE Plasma 5.13.5
KDE Frameworks 5.55.0
QtWebEngine 5.12.2
Qt (QtBase etc.) 5.11.3
Comment 1 David Rosca 2019-04-17 14:33:28 UTC
Works here, latest ArchLinux.
Does it work for other KDE apps for you? Also please note that now drkonqi just shows notifications and is not opened until you click on the icon in tray.
Comment 2 Kevin Kofler 2019-04-17 15:02:09 UTC
Hmmm, this is interesting…

If I try this with KWrite, I get the DrKonqi tray icon if KWrite was run from Konsole, but not if it was run from the menu. (Huh?) With Falkon, I never get the DrKonqi tray icon no matter how Falkon was run, even if I run it from the same Konsole from which I started KWrite when KCrash worked.
Comment 3 David Rosca 2019-04-20 19:21:58 UTC
Actually here it works even without calling KCrash::init(), just loading the libKF5Crash library is enough. It happens when loading all available plugins when opening Preferences.
Comment 4 Kevin Kofler 2019-08-10 10:06:34 UTC
You need something like this:
https://cgit.kde.org/kdevelop.git/commit/?id=ef0af08a9d4889ec5295a788900d1f38af67bb8a

I can confirm that running:
falkon &
killall -SIGABRT falkon
in a Konsole gives me a backtrace from Chromium to the Konsole, whereas running:
QTWEBENGINE_CHROMIUM_FLAGS=--disable-in-process-stack-traces falkon &
killall -SIGABRT falkon
gives me DrKonqi as expected.
Comment 5 Kevin Kofler 2019-08-10 10:07:47 UTC
Reassigning back to Falkon as there is clearly a Falkon bug here. Though there may be a KCrash bug too (see comment #2), I may have to file a second bug.
Comment 6 Kevin Kofler 2019-08-10 10:20:35 UTC
I also finally managed to track down the issue from comment #2. It appears to be due to the plasmashell respawning on crash, see bug #410785.

So let us please focus on Falkon in this bug, see comment #4.
Comment 7 Kevin Kofler 2019-08-29 11:38:27 UTC
Ping? Can we get something like this:
https://cgit.kde.org/kdevelop.git/commit/?id=ef0af08a9d4889ec5295a788900d1f38af67bb8a
added to Falkon so that KCrash integration actually works?
Comment 8 Kevin Kofler 2020-03-30 13:08:15 UTC
Ping?
Comment 9 Raphael Groner 2020-03-30 13:22:33 UTC
My vote goes for this, due to actually crashes reported inside (alternative) downstream abrt itself.
Comment 10 Kevin Kofler 2020-06-25 22:56:03 UTC
Ping?
Comment 11 Justin Zobel 2020-10-25 06:31:21 UTC
I've tested with Falkon 3.1.0 using your examples.

Run falkon from konsole and from menu.

When calling killall -SIGABRT falkon both times I was presented with the DrKonqi tray icon and a notification.

Can you please re-test and confirm.
Comment 12 Justin Zobel 2020-10-25 06:31:56 UTC
Operating System: Solus 4.1
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 13 Bug Janitor Service 2020-11-09 04:33:54 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 14 Raphael Groner 2020-11-09 05:55:12 UTC
Kevin, what's the actual state for this issue in downstream Fedora?
Comment 15 Kevin Kofler 2020-11-09 10:25:30 UTC
Unfortunately, I'm still running outdated Fedora versions at this time. Can you or some other Fedora user test this? I somehow cannot believe that this is magically fixed, considering that nothing was done to fix it (as far as I can tell, also not in Qt upstream nor in Chromium).
Comment 16 Justin Zobel 2020-11-09 22:17:35 UTC
This appears to be a downstream issue with Fedora. I just tested with a live Fedora 33 KDE ISO and it won't bring up DrKonqi when I SIGABRT falkon but it does when I do it to konsole.

I'd suggest raising with the Fedora team.
Comment 17 Kevin Kofler 2020-11-10 00:47:09 UTC
This is absurd. I have pointed out very clearly at what needs to be fixed in this upstream code. See also: https://www.dvratil.cz/2018/10/drkonqi-and-qtwebengine/ . This is clearly an upstream issue. I have no idea why your distro is not affected. It might be setting QTWEBENGINE_CHROMIUM_FLAGS=--disable-in-process-stack-traces systemwide or have some other downstream workaround.