Bug 406352 - valgrind 3.15.0-RC1 fails cachegrind/callgrind ann tests because of missing a.c
Summary: valgrind 3.15.0-RC1 fails cachegrind/callgrind ann tests because of missing a.c
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.15 SVN
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-09 12:06 UTC by Mark Wielaard
Modified: 2019-04-10 15:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2019-04-09 12:06:21 UTC
cachegrind/tests/ann1                    (post)
cachegrind/tests/ann2                    (post)
callgrind/tests/ann1                     (post)
callgrind/tests/ann2                     (post)

These testcases fail because the RC1 dist tar is missing the a.c (auto-annotated) source file. It is missing because it isn't listed in EXTRA_DIST.

Proposed patch:

diff --git a/cachegrind/tests/Makefile.am b/cachegrind/tests/Makefile.am
index f2f8902..2722541 100644
--- a/cachegrind/tests/Makefile.am
+++ b/cachegrind/tests/Makefile.am
@@ -10,8 +10,8 @@ DIST_SUBDIRS = x86 .
 
 dist_noinst_SCRIPTS = filter_stderr filter_cachesim_discards
 
-# Note that test.c is not compiled. It just serves as input for cg_annotate in
-# ann1 and ann2.
+# Note that test.c and a.c are not compiled.
+# They just serves as input for cg_annotate in ann1 and ann2.
 EXTRA_DIST = \
        cgout-test \
        ann1.post.exp ann1.stderr.exp ann1.vgtest \
@@ -20,7 +20,7 @@ EXTRA_DIST = \
        clreq.vgtest clreq.stderr.exp \
        dlclose.vgtest dlclose.stderr.exp dlclose.stdout.exp \
        notpower2.vgtest notpower2.stderr.exp \
-       test.c \
+       test.c a.c \
        wrap5.vgtest wrap5.stderr.exp wrap5.stdout.exp
 
 check_PROGRAMS = \
Comment 1 Nick Nethercote 2019-04-10 00:56:17 UTC
> +# They just serves as input for cg_annotate in ann1 and ann2.

s/serves/serve/
Comment 2 Mark Wielaard 2019-04-10 15:02:01 UTC
commit 08f20ed4afadf6134ca7e164416e98a1a60e0baa
Author: Mark Wielaard <mark@klomp.org>
Date:   Tue Apr 9 14:47:05 2019 +0200

    Add missing cachegrind/tests/a.c to EXTRA_DIST.
    
    cachegrind/callgrind fails ann[12] tests because of missing a.c
    
    These testcases fail because the dist tar is missing the a.c
    (auto-annotated) source file. Fix by adding it to EXTRA_DIST.
    
    https://bugs.kde.org/show_bug.cgi?id=406352