The following example: Some text in markdown format  Some more text in markdown format should ideally display "image.png" embedded within the text (if attached in the email, of course).
I tested this in Discount and works as expected, embedding the image within other markdown content. Could you please consider adding this option?
option for what ? Generating a image.png ?
(In reply to Laurent Montel from comment #2) > option for what ? > Generating a image.png ? I meant for adding images within context. Imaging you write a markdown email and you refer to one or more images in the body of the email. Discount allows to generate an html version of it that embeds the referenced image in its right place. It would be great if Kmail would benefit from this, so referenced images are embedded in the right places of the email body. For this, Kmail would need to be smart enough to know where to find the image (that needs of course to be attached to the email). I hope I was clearer this time :)
Git commit 767d21f55ef2447f67790c033762c51a4d6e1ff1 by Laurent Montel. Committed on 16/04/2019 at 11:27. Pushed by mlaurent into branch 'master'. Add method for generating image markdown string. For the moment it doesn't add image in mail M +2 -0 kmail/editorconvertertextplugins/markdown/CMakeLists.txt M +4 -2 kmail/editorconvertertextplugins/markdown/autotests/CMakeLists.txt A +46 -0 kmail/editorconvertertextplugins/markdown/autotests/markdowncreateimagedialogtest.cpp [License: LGPL (v2+)] A +35 -0 kmail/editorconvertertextplugins/markdown/autotests/markdowncreateimagedialogtest.h [License: LGPL (v2+)] A +59 -0 kmail/editorconvertertextplugins/markdown/autotests/markdowncreateimagewidgettest.cpp [License: LGPL (v2+)] A +36 -0 kmail/editorconvertertextplugins/markdown/autotests/markdowncreateimagewidgettest.h [License: LGPL (v2+)] A +52 -0 kmail/editorconvertertextplugins/markdown/markdowncreateimagedialog.cpp [License: LGPL (v2+)] A +36 -0 kmail/editorconvertertextplugins/markdown/markdowncreateimagedialog.h [License: LGPL (v2+)] A +52 -0 kmail/editorconvertertextplugins/markdown/markdowncreateimagewidget.cpp [License: LGPL (v2+)] A +38 -0 kmail/editorconvertertextplugins/markdown/markdowncreateimagewidget.h [License: LGPL (v2+)] M +14 -0 kmail/editorconvertertextplugins/markdown/markdowninterface.cpp M +1 -0 kmail/editorconvertertextplugins/markdown/markdowninterface.h https://commits.kde.org/kdepim-addons/767d21f55ef2447f67790c033762c51a4d6e1ff1
(In reply to avlas from comment #1) > I tested this in Discount and works as expected, embedding the image within > other markdown content. Could you please consider adding this option? How did you test it ? Could you give me your command line ? thanks
Created attachment 119432 [details] File to test markdown format conversion
(In reply to Laurent Montel from comment #5) > (In reply to avlas from comment #1) > > I tested this in Discount and works as expected, embedding the image within > > other markdown content. Could you please consider adding this option? > > How did you test it ? > Could you give me your command line ? > thanks I do: mkd2html -G -css github.css mainTest.md mainTest_github.html
Created attachment 119433 [details] File of github style for markdown conversion
In addition to the github css style (that I attached) I have another css file from markdown-here. The one I use (and like the most) is the github one, with single exception, the background color that is used in the title row of tables, which is taken from markdown-here. It would be ideal to, for instance, use the github style by default but allow the final user to add a specific css file in settings, if desired.
(In reply to avlas from comment #7) > (In reply to Laurent Montel from comment #5) > > (In reply to avlas from comment #1) > > > I tested this in Discount and works as expected, embedding the image within > > > other markdown content. Could you please consider adding this option? > > > > How did you test it ? > > Could you give me your command line ? > > thanks > > I do: > > mkd2html -G -css github.css mainTest.md mainTest_github.html Forgot to say about the image, which I didn't attach (as it may have copyright). Please change it by one that you have to test.
Thanks I will continue to implement it today or tomorrow
(In reply to Laurent Montel from comment #11) > Thanks I will continue to implement it today or tomorrow Thank you very much! If you implement all these enhancements, it's going to be amazing!
Git commit 137430312149daa2a95109160d236ad7c70d14a6 by Laurent Montel. Committed on 25/04/2019 at 07:11. Pushed by mlaurent into branch 'master'. Fix Bug 406334 - Markdown addon: embedded images (attached to the email) are not displayed FIXED-IN: 5.12.0 M +6 -5 kmail/editorconvertertextplugins/markdown/markdowninterface.cpp https://commits.kde.org/kdepim-addons/137430312149daa2a95109160d236ad7c70d14a6
(In reply to Laurent Montel from comment #13) > Git commit 137430312149daa2a95109160d236ad7c70d14a6 by Laurent Montel. > Committed on 25/04/2019 at 07:11. > Pushed by mlaurent into branch 'master'. > > Fix Bug 406334 - Markdown addon: embedded images (attached to the email) are > not displayed > FIXED-IN: 5.12.0 > > M +6 -5 > kmail/editorconvertertextplugins/markdown/markdowninterface.cpp > > https://commits.kde.org/kdepim-addons/ > 137430312149daa2a95109160d236ad7c70d14a6 Great, thanks! Do you think there could be a way to apply styling? I think it would be the last missing piece
(In reply to avlas from comment #14) > (In reply to Laurent Montel from comment #13) > > Git commit 137430312149daa2a95109160d236ad7c70d14a6 by Laurent Montel. > > Committed on 25/04/2019 at 07:11. > > Pushed by mlaurent into branch 'master'. > > > > Fix Bug 406334 - Markdown addon: embedded images (attached to the email) are > > not displayed > > FIXED-IN: 5.12.0 > > > > M +6 -5 > > kmail/editorconvertertextplugins/markdown/markdowninterface.cpp > > > > https://commits.kde.org/kdepim-addons/ > > 137430312149daa2a95109160d236ad7c70d14a6 > > Great, thanks! > > Do you think there could be a way to apply styling? I think it would be the > last missing piece It's still on my todo list (+ some others fix/improvement) See you if I will find a fix for it too :)
(In reply to Laurent Montel from comment #15) > (In reply to avlas from comment #14) > > (In reply to Laurent Montel from comment #13) > > > Git commit 137430312149daa2a95109160d236ad7c70d14a6 by Laurent Montel. > > > Committed on 25/04/2019 at 07:11. > > > Pushed by mlaurent into branch 'master'. > > > > > > Fix Bug 406334 - Markdown addon: embedded images (attached to the email) are > > > not displayed > > > FIXED-IN: 5.12.0 > > > > > > M +6 -5 > > > kmail/editorconvertertextplugins/markdown/markdowninterface.cpp > > > > > > https://commits.kde.org/kdepim-addons/ > > > 137430312149daa2a95109160d236ad7c70d14a6 > > > > Great, thanks! > > > > Do you think there could be a way to apply styling? I think it would be the > > last missing piece > > It's still on my todo list (+ some others fix/improvement) > > See you if I will find a fix for it too :) Very much appreciated!
now we can define the size of image (using =<width>x<height>)
(In reply to Laurent Montel from comment #17) > now we can define the size of image (using =<width>x<height>) Nice!
(In reply to Laurent Montel from comment #13) > Git commit 137430312149daa2a95109160d236ad7c70d14a6 by Laurent Montel. > Committed on 25/04/2019 at 07:11. > Pushed by mlaurent into branch 'master'. > > Fix Bug 406334 - Markdown addon: embedded images (attached to the email) are > not displayed > FIXED-IN: 5.12.0 > > M +6 -5 > kmail/editorconvertertextplugins/markdown/markdowninterface.cpp > > https://commits.kde.org/kdepim-addons/ > 137430312149daa2a95109160d236ad7c70d14a6 Not sure there has been a regression of some sort, but attached images are not displayed in markdown formatted html emails.
(In reply to avlas from comment #19) > (In reply to Laurent Montel from comment #13) > > Git commit 137430312149daa2a95109160d236ad7c70d14a6 by Laurent Montel. > > Committed on 25/04/2019 at 07:11. > > Pushed by mlaurent into branch 'master'. > > > > Fix Bug 406334 - Markdown addon: embedded images (attached to the email) are > > not displayed > > FIXED-IN: 5.12.0 > > > > M +6 -5 > > kmail/editorconvertertextplugins/markdown/markdowninterface.cpp > > > > https://commits.kde.org/kdepim-addons/ > > 137430312149daa2a95109160d236ad7c70d14a6 > > Not sure there has been a regression of some sort, but attached images are > not displayed in markdown formatted html emails. Test case ? For me it seems working here.
(In reply to Laurent Montel from comment #20) > (In reply to avlas from comment #19) > > (In reply to Laurent Montel from comment #13) > > > Git commit 137430312149daa2a95109160d236ad7c70d14a6 by Laurent Montel. > > > Committed on 25/04/2019 at 07:11. > > > Pushed by mlaurent into branch 'master'. > > > > > > Fix Bug 406334 - Markdown addon: embedded images (attached to the email) are > > > not displayed > > > FIXED-IN: 5.12.0 > > > > > > M +6 -5 > > > kmail/editorconvertertextplugins/markdown/markdowninterface.cpp > > > > > > https://commits.kde.org/kdepim-addons/ > > > 137430312149daa2a95109160d236ad7c70d14a6 > > > > Not sure there has been a regression of some sort, but attached images are > > not displayed in markdown formatted html emails. > > Test case ? > For me it seems working here. Please see: https://i.imgur.com/moqaQSv.png The image is missing and if I send the email anyway, I cannot find the image in the resulting email
I confirm it. I will investigate it
(In reply to Laurent Montel from comment #22) > I confirm it. > I will investigate it Thank you
I still can reproduce the issue