Bug 406262 - Some characters are replaced with "?" in "CDDB information.txt" file
Summary: Some characters are replaced with "?" in "CDDB information.txt" file
Status: RESOLVED FIXED
Alias: None
Product: AudioCD-KIO
Classification: Frameworks and Libraries
Component: General (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-05 18:13 UTC by Patrick Silva
Modified: 2019-06-17 10:02 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/audiocd-kio/2197d5d476178c76944fb0df4f08dbb2d0871c2f
Version Fixed In:

Attachments
screenshot (302.85 KB, image/png)
2019-04-05 18:19 UTC, Patrick Silva 		Details
Patch to use UTF-8 for strings (511 bytes, patch)
2019-04-05 18:44 UTC, Yuri Chornoivan 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-04-05 18:13:38 UTC 
SUMMARY
See the screenshot please. Disc name is "Hot Rocks 1964-1971", txt file says "Hot Rocks 1964?1971", first track is "Jumpin' Jack Flash", txt file says "Jumpin? Jack Flash", track 6 is "You Can't Always Get What You Want", txt file says "You Can?t Always Get What You Want".

STEPS TO REPRODUCE
1. insert an audio cd
2. open the inserted disc with Dolphin
3. open "Information" folder, open some txt file 

OBSERVED RESULT
some characters are replaced with "?" in the txt file


EXPECTED RESULT
no character is replaced with "?"

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.56.0
Qt Version: 5.13.0 beta1
Comment 1 Patrick Silva 2019-04-05 18:19:40 UTC 
Created attachment 119263 [details]
screenshot
Comment 2 Yuri Chornoivan 2019-04-05 18:44:51 UTC 
Created attachment 119264 [details]
Patch to use UTF-8 for strings

Can you test this patch?

Thanks in advance for testing.
Comment 3 Patrick Silva 2019-04-05 19:09:02 UTC 
Unfortunately I do not know how to apply your patch. :(
Comment 4 Yuri Chornoivan 2019-04-05 19:22:44 UTC 
(In reply to Patrick Silva from comment #3)
> Unfortunately I do not know how to apply your patch. :(

Is it an appropriate way to handle the things for you to build and install audiocd-kio from source on your machine?

If so,

git clone git://anongit.kde.org/audiocd-kio.git
cd audiocd-kio

Edit audiocd.cpp:490:
replace

				data(QByteArray( (*it).toString().toLatin1() ));

with
				data(QByteArray( (*it).toString().toUtf8() ));

mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_PLUGINDIR=/usr/lib64/qt5/plugins ..
make -j3
su -c "make install/strip"
Comment 5 Patrick Silva 2019-06-16 17:44:01 UTC 
This bug persists.

Operating System: Arch Linux 
KDE Plasma Version: 5.16.0
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3
Comment 6 Yuri Chornoivan 2019-06-17 05:49:27 UTC 
Differential Revision: https://phabricator.kde.org/D21870
Comment 7 Yuri Chornoivan 2019-06-17 10:02:56 UTC 
Git commit 2197d5d476178c76944fb0df4f08dbb2d0871c2f by Yuri Chornoivan.
Committed on 17/06/2019 at 10:02.
Pushed by yurchor into branch 'Applications/19.04'.

Use Unicode by default for CD-info data
Differential Revision: https://phabricator.kde.org/D21870

M  +1    -1    audiocd.cpp

https://commits.kde.org/audiocd-kio/2197d5d476178c76944fb0df4f08dbb2d0871c2f