Bug 406226 - adding tags to a selection from a large list of no-tags images takes a very long time
Summary: adding tags to a selection from a large list of no-tags images takes a very l...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (other bugs)
Version First Reported In: 6.0.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-04 17:42 UTC by Ben
Modified: 2019-04-18 06:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben 2019-04-04 17:42:00 UTC
SUMMARY


STEPS TO REPRODUCE
1. toggle 'no tags' in a library that contains lots of no-tags images
2. select a couple of images
3. apply a tag using the side bar tag window

OBSERVED RESULT

UI becomes non responsive for a solid minute while digikam seems to iterate through all the images that are still 'no tags' after the operation, complaining about missing thumbnails, etc, or whatever reaction each image provokes

EXPECTED RESULT

no such re-scanning of images that are still 'no-tag'. not sure if this is really what happens, but that's the only activity I can see during this time of unresponsiveness.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: scientific linux release 6.8 (Carbon), Gnome 2.28.2
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2019-04-18 06:02:33 UTC
Git commit a6e93d0ab64fc78c01e42e85f1a43baf71188507 by Maik Qualmann.
Committed on 17/04/2019 at 10:40.
Pushed by mqualmann into branch 'master'.

check faster the disjoint Metadata from items

M  +50   -10   core/libs/properties/captions/disjointmetadata.cpp
M  +14   -0    core/libs/properties/captions/itemdescedittab.cpp

https://commits.kde.org/digikam/a6e93d0ab64fc78c01e42e85f1a43baf71188507