Bug 406163 - Qt 5.12.2 - Test failure - DolphinMainWindowTest::testNewFileMenuEnabled(home)
Summary: Qt 5.12.2 - Test failure - DolphinMainWindowTest::testNewFileMenuEnabled(home)
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 18.12.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-02 19:36 UTC by Rik Mills
Modified: 2019-04-07 20:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2019-04-02 19:36:50 UTC
SUMMARY

With Qt 5.12.2 the DolphinMainWindowTest::testNewFileMenuEnabled(home) test fails with:

FAIL!  : DolphinMainWindowTest::testNewFileMenuEnabled(home) Compared values are not the same
   Actual   (newFileMenu->isEnabled()): 0
   Expected (expectedEnabled)         : 1
   Loc: [/tmp/autopkgtest.AlAChC/build.UlA/src/src/tests/dolphinmainwindowtest.cpp(250)]

http://autopkgtest.ubuntu.com/packages/d/dolphin/disco/amd64

Linux: Ubuntu 19.04
KDE Plasma Version: 5.15.3
KDE Frameworks Version: 5.56
Qt Version: 5.12.2

Testing on an actual system, the menu does have the correct enabled/disabled status in home/root/trash, so fail is incorrect.
Comment 1 Elvis Angelaccio 2019-04-06 16:50:31 UTC
Yeah Qt 5.12 changed something which broke this test. Needs investigation.
Comment 2 Elvis Angelaccio 2019-04-07 20:50:09 UTC
Fixed with https://commits.kde.org/dolphin/30a335cbcf1268bd35e6916c3649ec1b40134858

The test was just broken and I don't know how it was possibly working before...