Bug 406143 - we can't modify or delete a storage location
Summary: we can't modify or delete a storage location
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: android-application (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-02 09:59 UTC by Philippe ROUBACH
Modified: 2020-11-21 10:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe ROUBACH 2019-04-02 09:59:20 UTC
SUMMARY


STEPS TO REPRODUCE
1. create a storage location
2. try to change the selected folder
3. there is no possibility to do that
4. try to delete the storage location
5. there is no possibility to do that

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.15.3
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.2

ADDITIONAL INFORMATION
android kdeconnect 1.12.6
Comment 1 Nicolas Fella 2019-04-02 16:08:47 UTC
I don't think a dedicated edit mode adds much value. It would be rarely done and the same can be achieved by deleting the old location and adding a new one.

Deleting is possible by long-pressing and tapping the trash icon. However, it causes an exception for me:

java.lang.SecurityException: No permission grants found for UID 10133 and Uri content://com.android.externalstorage.documents/tree/primary:
        at android.os.Parcel.createException(Parcel.java:1950)
        at android.os.Parcel.readException(Parcel.java:1918)
        at android.os.Parcel.readException(Parcel.java:1868)
        at android.app.IActivityManager$Stub$Proxy.releasePersistableUriPermission(IActivityManager.java:7486)
        at android.content.ContentResolver.releasePersistableUriPermission(ContentResolver.java:2173)
        at org.kde.kdeconnect.Plugins.SftpPlugin.SftpSettingsFragment.onActionItemClicked(SftpSettingsFragment.java:477)
        at androidx.appcompat.app.AppCompatDelegateImpl$ActionModeCallbackWrapperV9.onActionItemClicked(AppCompatDelegateImpl.java:2171)
        at androidx.appcompat.app.WindowDecorActionBar$ActionModeImpl.onMenuItemSelected(WindowDecorActionBar.java:1123)
        at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:840)
        at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:158)
        at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:991)
        at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:981)
        at androidx.appcompat.widget.ActionMenuView.invokeItem(ActionMenuView.java:625)
        at androidx.appcompat.view.menu.ActionMenuItemView.onClick(ActionMenuItemView.java:151)
        at android.view.View.performClick(View.java:6597)
        at android.view.View.performClickInternal(View.java:6574)
        at android.view.View.access$3100(View.java:778)
        at android.view.View$PerformClick.run(View.java:25885)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6718)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
     Caused by: android.os.RemoteException: Remote stack trace:
        at com.android.server.am.ActivityManagerService.releasePersistableUriPermission(ActivityManagerService.java:10580)
        at android.app.IActivityManager$Stub.onTransact(IActivityManager.java:2175)
        at com.android.server.am.ActivityManagerService.onTransact(ActivityManagerService.java:3377)
        at android.os.Binder.execTransact(Binder.java:731)
Comment 2 Nicolas Fella 2019-04-02 16:15:26 UTC
Actually editing is possible by tapping the entry
Comment 3 Nicolas Fella 2019-04-02 16:16:24 UTC
(In reply to Nicolas Fella from comment #2)
> Actually editing is possible by tapping the entry

NVM, editing the actual path is not possible
Comment 4 Nicolas Fella 2019-04-02 16:32:46 UTC
My phone was in a weird state so deleting usually works fine.
https://invent.kde.org/kde/kdeconnect-android/merge_requests/47 tries to solve the corner case I hit
Comment 5 Erik Duisters 2019-04-02 17:16:44 UTC
This is weird. How can you not have a granted permission when you do have a storage location configured? I'll try to look into this during the weekend.
Comment 6 Justin Zobel 2020-11-21 04:05:33 UTC
I've just tested this on the current KDEConnect and I can delete by long-pressing on an entry.

As mentioned the value in editing is low.

Philippe can you please test and confirm if this is still an issue or if this bug report can be marked as resolved. I've set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thanks.
Comment 7 Philippe ROUBACH 2020-11-21 10:15:50 UTC
kdeconnect android 1.15.1
kdeconnect kde 20.08.3
Samsung S7 android 8.1

we can drag and drop a folder or a file.
we can cut and past a folder or a file.
we can rename a folder or a file.

we can organize our data. for my case there is no more problem.