Bug 406021 - Ekos solver options does not save --no-fits2fits option
Summary: Ekos solver options does not save --no-fits2fits option
Status: RESOLVED DOWNSTREAM
Alias: None
Product: kstars
Classification: Applications
Component: general (show other bugs)
Version: 3.1.1
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Jasem Mutlaq
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-29 22:24 UTC by James Harrison
Modified: 2019-04-14 20:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Harrison 2019-03-29 22:24:42 UTC
SUMMARY

In the align -> options panel, there is a basic option for --no-fits2fits. This option is not saved across kstars restarts. On systems where --nofits2fits is not required, this means alignment will always fail by default.


STEPS TO REPRODUCE
1. Uncheck "--nofits2fits" in Solver Options
2. Close Ekos/KStars
3. Open Ekos/KStars

OBSERVED RESULT
--no-fits2fits is checked again

EXPECTED RESULT
--no-fits2fits is not checked

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch, latest flavours of everything, 3.1.1 kstars.

ADDITIONAL INFORMATION
Other options appear to save correctly (for instance, the differential slewing option).
Comment 1 Jasem Mutlaq 2019-03-30 06:21:14 UTC
It's getting checked again because KStars detects an older astrometry.net that requires it. Are you trying ti uncheck it for the "remote" option? What version do you have on the machine running KStars?
Comment 2 James Harrison 2019-03-30 11:26:55 UTC
(In reply to Jasem Mutlaq from comment #1)
> It's getting checked again because KStars detects an older astrometry.net
> that requires it. Are you trying ti uncheck it for the "remote" option? What
> version do you have on the machine running KStars?

Aha! Right, this is all running locally and the local version is 0.77 from git (using the Arch AUR packaging: https://aur.archlinux.org/packages/astrometry.net/ ). The issue is in the Arch packaging.

Looking at the OfflineAstrometryParser::init() function I see it's doing a shell out to bash, running solve-field --help | grep Revision and looking for a version number. I'm not sure what "good" looks like, but on my system that yields:

Revision , date Tue_Nov_13_12:41:09_2018_+0800.

From reading astronomy.net's code, after "Revision" should be the version tag and git commit hash but this doesn't get done in from-source builds, only in the release function. Even released source doesn't have this set, from my reading; the AUR package is just grabbing the source release and building it.

I've worked around this by adding the following line to the AUR PKGBUILD's prepare function:

sed "s/AN_GIT_REVISION .=.*/AN_GIT_REVISION := ${pkgver}/" -i util/makefile.common

I will get this back into the AUR version.

It's probably safer to default to not using --nofits2fits and assuming a modern build where there's no version information available, but this can be closed.
Comment 3 Bug Janitor Service 2019-04-14 04:33:08 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 James Harrison 2019-04-14 20:02:22 UTC
Happy to report the AUR package for Arch is now building from the correct release source for astrometry.net and thus correctly sets its version string; KStars now correctly identifies it as not needing --nofits2fits and works out of the box. Thanks for the help!