SUMMARY On Wayland, currently "Fall apart" effect is triggered when menus, context menus, dropdowns and dialogs such to confirm file deletion on Dolphin are closed. STEPS TO REPRODUCE 1. On Wayland session, enable "Fall apart" effect in "Desktop effects" kcm 2. open and close some menu, context menu, dropdown or dialog box EXPECTED RESULT Only trigger "Fall apart" effect when a window is closed, like on X11. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.15.3 KDE Frameworks Version: 5.56.0 Qt Version: 5.12.2
On Wayland we don't have window types yet, so it's tricky to get this done.
(In reply to Martin Flöser from comment #1) > On Wayland we don't have window types yet, so it's tricky to get this done. I think isPopupWindow() could be used to filter out popups though not dialogs... :(
Created attachment 119148 [details] screen recording on X11 The effect is triggered by some dropdows on X11 too.
On X11 the effect is also triggered when I minimize an app by clicking its icon in systray. For example, install SMPlayer and open it, click "Options" menu, check "Show icon in system tray". Now minimize SMPlayer by clicking its systray icon: "Fall apart" effect was triggered. Operating System: Arch Linux KDE Plasma Version: 5.15.4 KDE Frameworks Version: 5.57.0 Qt Version: 5.12.2
>On Wayland we don't have window types yet It's not something anyone has requested on xdgshell. If we do want this, one of us needs to actually request it on wayland-devel. >I think isPopupWindow() could be used to filter out popups though not dialogs... Seems sensible.
(In reply to Patrick Silva from comment #4) > On X11 the effect is also triggered when I minimize an app by clicking its > icon in systray. As expected.
Git commit 0a8c436f7f055ff27cda99d757cbd135cc3a6494 by Vlad Zagorodniy. Committed on 15/04/2019 at 08:20. Pushed by vladz into branch 'Plasma/5.15'. [effects/fallapart] Don't animate popups Summary: BUG: 405971 Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D20568 M +6 -0 effects/fallapart/fallapart.cpp https://commits.kde.org/kwin/0a8c436f7f055ff27cda99d757cbd135cc3a6494
(In reply to Vlad Zagorodniy from comment #6) > (In reply to Patrick Silva from comment #4) > > On X11 the effect is also triggered when I minimize an app by clicking its > > icon in systray. > > As expected. Why the effect is not triggered when a window (of qBittorrent, for example) is minimized to systray via click on minimize button of its window decoration?
(In reply to Patrick Silva from comment #8) > Why the effect is not triggered when a window (of qBittorrent, for example) > is minimized to systray via click on minimize button of its window > decoration? Because it actually gets minimized (i.e. it's in the Iconic state). As far as I know, there isn't such a thing as "minimize to systray".
Hummm, the effect is triggered when you minimize a window to systray by clicking its icon in systray but it is not when the same window is minimized by clicking the button of the window decoration... This is an inconsistent behavior. Should I open a report about this issue?
No, it works "as intended."