Bug 405833 - pyfalkon doesn't build with pyside 5.12.2
Summary: pyfalkon doesn't build with pyside 5.12.2
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: extensions (show other bugs)
Version: 3.1.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-24 19:57 UTC by Antonio Rojas
Modified: 2019-06-03 15:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 3.1.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2019-03-24 19:57:34 UTC
SUMMARY
pyside 5.12.2 breaks build of pyfalkon - in commit [1] shiboken and pyside cmake files stopped exporting all variables used in falkon


[1] https://code.qt.io/cgit/pyside/pyside-setup.git/commit/?id=97df448edbc035a2f531508a5cfe5739fb2de18d
Comment 1 David Rosca 2019-03-24 20:03:07 UTC
find_package(Shiboken2 "2.0.0") now fails:

CMake Error at /usr/lib64/cmake/Shiboken2-5.12.2/shiboken_helpers.cmake:160 (shiboken_get_library_for_current_config):
  shiboken_get_library_for_current_config Function invoked with incorrect
  arguments for function named: shiboken_get_library_for_current_config
Call Stack (most recent call first):
  /usr/lib64/cmake/Shiboken2-5.12.2/Shiboken2Config.cpython-37m-x86_64-linux-gnu.cmake:58 (shiboken_compute_python_libraries)
  /usr/lib64/cmake/Shiboken2-5.12.2/Shiboken2Config.cmake:5 (include)
  CMakeLists.txt:123 (find_package)

It's broken in PySide though.
Comment 2 Antonio Rojas 2019-03-24 20:04:44 UTC
Yeah, that's https://bugreports.qt.io/browse/PYSIDE-980 - set CMAKE_BUILD_TYPE to get to the real fun
Comment 3 David Rosca 2019-03-25 08:09:34 UTC
I've got it almost fixed, the only thing left is to link against correct Python libs.

Let's see what's the verdict here https://bugreports.qt.io/browse/PYSIDE-982
Comment 4 David Rosca 2019-03-25 10:38:38 UTC
Git commit 479933e095168d07a54913f88642cfed4828c167 by David Rosca.
Committed on 25/03/2019 at 10:38.
Pushed by drosca into branch 'Falkon/3.1'.

PyFalkon: Fix build with Qt 5.12.2
FIXED-IN: 3.1.1

M  +5    -5    CMakeLists.txt
M  +8    -10   src/plugins/PyFalkon/CMakeLists.txt

https://commits.kde.org/falkon/479933e095168d07a54913f88642cfed4828c167
Comment 5 Rik Mills 2019-04-17 14:05:42 UTC
Great, but this breaks builds if you have still have pyside2 5.11, which is not really acceptable.
Comment 6 David Rosca 2019-04-17 14:07:18 UTC
(In reply to Rik Mills from comment #5)
> Great, but this breaks builds if you have still have pyside2 5.11, which is
> not really acceptable.

Sorry, but tell that to Qt guys for breaking it.
Comment 7 Rik Mills 2019-04-17 14:09:41 UTC
(In reply to David Rosca from comment #6)
> (In reply to Rik Mills from comment #5)
> > Great, but this breaks builds if you have still have pyside2 5.11, which is
> > not really acceptable.
> 
> Sorry, but tell that to Qt guys for breaking it.

No, YOU broke builds with pyside2 < 5.12 with your commit

Some logic in the cmake here should allow both cases.
Comment 8 David Rosca 2019-04-17 14:13:29 UTC
(In reply to Rik Mills from comment #7)
> No, YOU broke builds with pyside2 < 5.12 with your commit
> 
> Some logic in the cmake here should allow both cases.

Sure, patches welcome.

You can either disable building PyFalkon or revert this commit if you need to use old Qt.
Comment 9 David Rosca 2019-06-03 15:43:09 UTC
Git commit 4b85dab3d7fa3ef267d043ee4cd37f78c5a8df50 by David Rosca.
Committed on 03/06/2019 at 15:42.
Pushed by drosca into branch 'master'.

Vertical tabs: Draw unloaded tabs with "Disabled" color palette

Summary: BUG: 405833

Reviewers: #falkon

Subscribers: falkon

Tags: #falkon

Differential Revision: https://phabricator.kde.org/D21548

M  +4    -0    src/plugins/VerticalTabs/tabtreedelegate.cpp

https://commits.kde.org/falkon/4b85dab3d7fa3ef267d043ee4cd37f78c5a8df50