Bug 405824 - Markdown syntax: give bullet lists a more readable color
Summary: Markdown syntax: give bullet lists a more readable color
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (other bugs)
Version First Reported In: 5.57.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2019-03-24 18:37 UTC by Gregor Mi
Modified: 2019-05-19 16:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.59
Sentry Crash Report:


Attachments
Markdown highlighting showing normal text and bullet lists (128.79 KB, image/png)
2019-03-24 18:37 UTC, Gregor Mi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Mi 2019-03-24 18:37:13 UTC
Created attachment 119004 [details]
Markdown highlighting showing normal text and bullet lists

Is it possible to give bullet lists and enumerations in the markdown highlighting a darker color? If there is much text in lists and enumerations, it becomes unnecessary hard to read, see screenshot.

E.g.:
#503c0c (a darker orange / brown)
#003b00 (a dark green / preferred)
Comment 1 Nibaldo G. 2019-05-19 10:45:27 UTC
The lists are highlighted with the "dsFloat" color style, which is yellow in the "Normal" scheme and orange in the "KDE" scheme, which can be difficult to read when there is a lot of text.

I propose to change dsFloat => dsString in lists
and dsBaseN => dsVerbatimString in code.

since the "dsString" color style is designed for text strings and is readable in all color schemes (this is red in most schemes).

what do you think?
Comment 2 Dominik Haumann 2019-05-19 16:02:23 UTC
Git commit 7be1380c52a85f6066d95d4fa9ba2914e4d0b6a9 by Dominik Haumann.
Committed on 19/05/2019 at 16:02.
Pushed by dhaumann into branch 'master'.

Markdown: Use color with higher contrast for lists

Summary:
FIXED-IN: 5.59

Test Plan: make && make test

Reviewers: cullmann, gregormi

Reviewed By: cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D21293

M  +2    -2    autotests/html/basic.markdown.html
M  +4    -4    autotests/html/test.markdown.html
M  +7    -7    data/syntax/markdown.xml

https://commits.kde.org/syntax-highlighting/7be1380c52a85f6066d95d4fa9ba2914e4d0b6a9