Bug 405598 - ContextDrawer can have handle icon customized, but GlobalDrawer cannot
Summary: ContextDrawer can have handle icon customized, but GlobalDrawer cannot
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-18 13:33 UTC by Nate Graham
Modified: 2019-08-14 19:08 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/kirigami/191ff22b1cb9121580abbc7f9baf72c992eb5a56
Version Fixed In: 5.62

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-03-18 13:33:02 UTC 
I can add `handleClosedIcon.source: "my-awesome-icon"` to a ContextDrawer to customize its icon, but doing this for the GlobalDrawer has no effect.
Comment 1 camiloh 2019-08-14 19:08:46 UTC 
Git commit 191ff22b1cb9121580abbc7f9baf72c992eb5a56 by Camilo Higuita.
Committed on 14/08/2019 at 19:08.
Pushed by camiloh into branch 'master'.

allow to set custom icon for the left drawer handle

Summary:
it allows to set a icon to the globaldrawer handle, for that both close and open handle icons need to be set
FIXED-IN: 5.62

Reviewers: #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: ngraham, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D23154

M  +2    -1    src/controls/ContextDrawer.qml
M  +3    -1    src/controls/GlobalDrawer.qml
M  +10   -13   src/controls/OverlayDrawer.qml

https://commits.kde.org/kirigami/191ff22b1cb9121580abbc7f9baf72c992eb5a56