Bug 405573 - "Touch Screen" KCM sets action to "Present windows - Current desktop" despite I select "Present windows - All desktops"
Summary: "Touch Screen" KCM sets action to "Present windows - Current desktop" despite...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwintouchscreen (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-17 19:20 UTC by Patrick Silva
Modified: 2020-04-22 09:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-03-17 19:20:06 UTC
STEPS TO REPRODUCE
1. open system settings > desktop behavior > touch screen
2. set any action for a gesture with the touch screen
3. click "Apply" button and reopen the touch screen kcm

OBSERVED RESULT
configuration done in the step 2 was lost.

EXPECTED RESULT
configuration done in the step 2 is saved

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.57.0
Qt Version: 5.12.0
Comment 1 Christoph Feck 2019-03-31 08:56:27 UTC
Cannot reproduce on openSUSE Krypton using "kcmshell5 kwintouchscreen". Both 'OK' and 'Apply' save the settings.
Comment 2 Patrick Silva 2019-03-31 17:50:06 UTC
Is the configuration saved if you set "Present windows - All desktops"?
Comment 3 Christoph Feck 2019-04-16 20:14:19 UTC
For whatever reason, on my system the only "Present Windows" option that is selectable there is "Present Windows - Current Application". Saving works with this option. The other "Present Windows" options (both All Desktops and Current Desktop) are greyed out.
Comment 4 Patrick Silva 2019-04-16 20:19:30 UTC
On my system I can select "Present windows - All desktops"
but such option is not saved. KCM always saves the option below it instead.
Comment 5 Patrick Silva 2020-01-19 15:43:26 UTC
This bug persists.

STEPS TO REPRODUCE
1. open system settings > workspace behavior > touch screen
2. set the action of any screen edge to "Present windows - All desktops"
3. close system settings
4. reopen system settings > workspace behavior > touch screen
5. check if "Present windows - All desktops" action configured in the step 2
was saved correctly.

OBSERVED RESULT
configuration done in the step 2 was not saved correctly.
KCM saved "Present windows - Current desktop" action instead of "Present windows - All desktops" selected by you.

EXPECTED RESULT
"Touch screen" KCM always saves any change correctly.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.67.0
Qt Version: 5.13.2
Comment 6 Cyril Rossi 2020-04-14 09:53:05 UTC
https://phabricator.kde.org/D27862
Comment 7 Cyril Rossi 2020-04-22 09:22:12 UTC
Git commit 01314f8e9a7315e35e0169c8fb99899d09a9692f by Cyril Rossi.
Committed on 22/04/2020 at 09:09.
Pushed by crossi into branch 'master'.

KCM KWinTouchScreen port to KConfigXT

Summary:
Also manage KCModule states (isSaveNeeded and isDefaults)

Test Plan:
* exec kcmshell5 kwintouchscreen
* In an edge, select action Present windows - All desktops, then apply
* close and reopen
* Should display action Present windows - All desktops in the previously selected edge.

* Do same test with Present windows - current desktop

Reviewers: #kwin, ervin, bport, meven, zzag

Reviewed By: #kwin, ervin, meven, zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D27862

M  +3    -1    kcmkwin/kwinscreenedges/CMakeLists.txt
A  +217  -0    kcmkwin/kwinscreenedges/kwinscreenedge.cpp     [License: GPL (v2)]
A  +83   -0    kcmkwin/kwinscreenedges/kwinscreenedge.h     [License: GPL (v2)]
A  +45   -0    kcmkwin/kwinscreenedges/kwintouchscreenedgeconfigform.cpp     [License: GPL (v2)]
A  +52   -0    kcmkwin/kwinscreenedges/kwintouchscreenedgeconfigform.h     [License: GPL (v2)]
A  +14   -0    kcmkwin/kwinscreenedges/kwintouchscreenscriptsettings.kcfg
A  +7    -0    kcmkwin/kwinscreenedges/kwintouchscreenscriptsettings.kcfgc
A  +56   -0    kcmkwin/kwinscreenedges/kwintouchscreensettings.kcfg
A  +7    -0    kcmkwin/kwinscreenedges/kwintouchscreensettings.kcfgc
M  +157  -283  kcmkwin/kwinscreenedges/touch.cpp
M  +18   -24   kcmkwin/kwinscreenedges/touch.h
M  +2    -2    kcmkwin/kwinscreenedges/touch.ui

https://commits.kde.org/kwin/01314f8e9a7315e35e0169c8fb99899d09a9692f