Bug 405512 - Meta Key Not Useful For Key Modifier In Windows
Summary: Meta Key Not Useful For Key Modifier In Windows
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Keyboard (other bugs)
Version First Reported In: 6.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-16 09:57 UTC by hardy.public
Modified: 2019-03-17 19:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.1.0
Sentry Crash Report:


Attachments
Shortcuts file for Windows (4.79 KB, text/plain)
2019-03-16 15:52 UTC, hardy.public
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hardy.public 2019-03-16 09:57:08 UTC
SUMMARY
In Windows, by default at least, the Meta (Windows) key has no influence on Digikam because it maps to OS actions.

STEPS TO REPRODUCE
Windows Key + A is configured as "Shown Assigned Tags" in Digikam.

OBSERVED RESULT
Windows Key + A opens the Windows Action Centre.

EXPECTED RESULT
I suppose the observed result is the expected result.

SOFTWARE/OS VERSIONS
Windows: 10

ADDITIONAL INFORMATION
I realise this is an issue with Windows only.

Suggest any of these:
For Windows, "Menu" can be used instead of "Meta":

a) When building the Windows version, substitute Menu for Meta.
or
b) Have 2 "Defaults" buttons in Configure Shortcuts. One for Windows one for other OS.
Comment 1 hardy.public 2019-03-16 10:01:09 UTC
If I start a new scheme, it's blank. Shouldn't the Defaults button apply to the new scheme?
Comment 2 hardy.public 2019-03-16 10:11:12 UTC
Workaround:
Export Default scheme.
Edit .shortcuts file and change Meta to Menu.
Start new scheme.
Import edited shortcuts file.
Comment 3 hardy.public 2019-03-16 15:48:40 UTC
(In reply to hardy.public from comment #0)
> SUMMARY
> In Windows, by default at least, the Meta (Windows) key has no influence on
> Digikam because it maps to OS actions.
> 
> STEPS TO REPRODUCE
> Windows Key + A is configured as "Shown Assigned Tags" in Digikam.
> 
> OBSERVED RESULT
> Windows Key + A opens the Windows Action Centre.
> 
> EXPECTED RESULT
> I suppose the observed result is the expected result.
> 
> SOFTWARE/OS VERSIONS
> Windows: 10
> 
> ADDITIONAL INFORMATION
> I realise this is an issue with Windows only.
> 
> Suggest any of these:
> For Windows, "Menu" can be used instead of "Meta":
> 
> a) When building the Windows version, substitute Menu for Meta.
> or
> b) Have 2 "Defaults" buttons in Configure Shortcuts. One for Windows one for
> other OS.

Actually Menu is a bad choice. Instead use Ctrl+Alt / 'Alt Gr'.
Comment 4 hardy.public 2019-03-16 15:52:42 UTC
Created attachment 118840 [details]
Shortcuts file for Windows

For Windows users, this file substitutes 'Ctrl+Alt' for 'Meta'.

In short, where it said 'Meta' in the defaults, just press the 'Alt Gr' key.
Comment 5 Maik Qualmann 2019-03-16 20:41:59 UTC
Gilles, what do you think? Change all Meta modifiers to Ctrl + Alt? Only on Windows? I am thinking of the longtime users. Different key combination between the operating system is likely to cause confusion. At the moment I would just like to change Meta + A as it is a global shortcut key under Windows10.

Maik
Comment 6 caulier.gilles 2019-03-16 20:54:20 UTC
Look LR keyboard Shortcuts :

https://www.lightroomqueen.com/keyboard-shortcuts/lrcc6/

There is no META key used here. So It sound a good compromise to drop META key in digiKam.

Gilles
Comment 7 Maik Qualmann 2019-03-16 21:20:53 UTC
Ok, we have Meta + Ctrl + F1 for album. With Ctrl + Alt + F1 we are on the console under Linux. This will be a puzzle and OSX is not there yet.

Maik
Comment 8 Maik Qualmann 2019-03-17 11:47:38 UTC
Git commit 243e1035f160540a3596a6216982449fb851a639 by Maik Qualmann.
Committed on 17/03/2019 at 11:46.
Pushed by mqualmann into branch 'master'.

remove Meta key from the shortcuts keys
FIXED-IN: 6.1.0

M  +2    -1    NEWS
M  +5    -5    core/app/main/digikamapp_setup.cpp
M  +9    -9    core/app/views/sidebar/leftsidebarwidgets.cpp
M  +1    -1    core/dplugins/generic/tools/htmlgallery/htmlgalleryplugin.cpp
M  +2    -2    core/dplugins/generic/webservices/filetransfer/ftplugin.cpp
M  +3    -3    core/dplugins/generic/webservices/google/gsplugin.cpp
M  +2    -2    core/dplugins/generic/webservices/smugmug/smugplugin.cpp
M  +6    -6    core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +1    -1    core/utilities/imageeditor/editor/editorwindow.cpp
M  +3    -3    core/utilities/imageeditor/main/imagewindow_setup.cpp
M  +1    -1    core/utilities/import/main/importui.cpp
M  +12   -12   core/utilities/lighttable/lighttablewindow_setup.cpp
M  +1    -1    core/utilities/queuemanager/main/queuemgrwindow.cpp

https://commits.kde.org/digikam/243e1035f160540a3596a6216982449fb851a639
Comment 9 caulier.gilles 2019-03-17 11:52:29 UTC
Maik,

Long time ago, i started to create this text file :

https://cgit.kde.org/digikam.git/tree/project/documents/KEYSHORTCUTS

It still valid but out of date.

The goal is to include these information in manual later...

Gilles
Comment 10 Maik Qualmann 2019-03-17 11:56:40 UTC
Please check if a new bundle of Windows is ready if everything works fine. It was not always possible to use CTRL + ALT because e.g. under Linux CTRL + ALT + T the console opens. Instead, we'll use ALT + SHIFT instead.

@Gilles, ok i can expand it from time to time.

Maik
Comment 11 caulier.gilles 2019-03-17 12:04:30 UTC
Hardy,

I will generate MacOS and Windows bundles today.

For Linux AppImage, i'm working on. Perhaps at least the 64 bits will be ready today, but i'm not sure...

Gilles Caulier
Comment 12 hardy.public 2019-03-17 16:51:41 UTC
(In reply to caulier.gilles from comment #11)
> Hardy,
> 
> I will generate MacOS and Windows bundles today.
> 
> For Linux AppImage, i'm working on. Perhaps at least the 64 bits will be
> ready today, but i'm not sure...
> 
> Gilles Caulier

Thanks for your hard work gentlemen. I just downloaded and installed digiKam-6.1.0-git-20190317T163011-Win64.exe and tested every Ctrl+Alt combo using the 'Alt Gr' key and it works very well.

I did not know that the 'Alt Gr' key on my keyboard was the same as pressing Ctrl+Alt until yesterday. The chances are that other users, who also don't know it, may complain of having to use too many fingers for shortcuts. Can I suggest that somehow you alert users of this tip? Perhaps somewhere in Configure Shortcut dialogue or maybe a one time pop-up when the user clicks Configure Shortcuts for the first time? Just an idea.
Comment 13 Maik Qualmann 2019-03-17 17:24:53 UTC
I think you've just tested your self-made scheme. Because CTRL + ALT uses the patch very rare. Most were switched to CTRL + SHIFT. ((:-)) Many CTRL + ALT combinations are used by Linux / KF5 Desktop.

Maik
Comment 14 hardy.public 2019-03-17 18:42:15 UTC
Hmmm, I don't think so. Unless something's got screwed up, I tested your new scheme. 

I installed the new package, deleted my schemes so I only have Default remaining, then clicked Defaults button. There's still a bunch of Ctrl+Alt combinations remaining, right?:

album_zoomfit2window=Ctrl+Alt+E
colorshortcut-0=Ctrl+Alt+0
colorshortcut-1=Ctrl+Alt+1
colorshortcut-2=Ctrl+Alt+2
colorshortcut-3=Ctrl+Alt+3
colorshortcut-4=Ctrl+Alt+4
colorshortcut-5=Ctrl+Alt+5
colorshortcut-6=Ctrl+Alt+6
colorshortcut-7=Ctrl+Alt+7
colorshortcut-8=Ctrl+Alt+8
colorshortcut-9=Ctrl+Alt+9
export_box=Ctrl+Alt+Shift+B
export_dropbox=Ctrl+Alt+Shift+D
export_facebook=Ctrl+Alt+Shift+F
export_flickr=Ctrl+Alt+Shift+R
export_googledrive=Ctrl+Alt+Shift+G
export_googlephoto=Ctrl+Alt+Shift+P
export_imageshack=Ctrl+Alt+Shift+M
export_onedrive=Ctrl+Alt+Shift+O
export_pinterest=Ctrl+Alt+Shift+I
export_rajce=Ctrl+Alt+Shift+J
export_smugmug=Ctrl+Alt+Shift+S
export_yandexfotki=Ctrl+Alt+Shift+Y
htmlgallery=Ctrl+Alt+Shift+H
import_addImages=Ctrl+Alt+I
next-left-sidebar-tab=Ctrl+Alt+End
next-right-sidebar-tab=Ctrl+Alt+PgDown
previous-left-sidebar-tab=Ctrl+Alt+Home
previous-right-sidebar-tab=Ctrl+Alt+PgUp
search_advanced=Ctrl+Alt+F
toggle-left-sidebar=Ctrl+Alt+Left
toggle-right-sidebar=Ctrl+Alt+Right

Are these different to what you've coded? If so, then it seems the Defaults button is unable to give me the keys you've coded in the package for some reason.
Comment 15 Maik Qualmann 2019-03-17 19:07:19 UTC
All ok, these CTRL + ALT shortcut keys exist.

Maik