Bug 405505 - Titlebars of shaded maximized windows are indistinguishable from titlebars of maximized windows underneath them
Summary: Titlebars of shaded maximized windows are indistinguishable from titlebars of...
Status: CONFIRMED
Alias: None
Product: Breeze
Classification: Plasma
Component: window decoration (show other bugs)
Version: 5.15.3
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-15 23:15 UTC by Noah Davis
Modified: 2020-04-01 07:44 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Shaded maximized Konsole window on top of a maximized Firefox window (65.96 KB, image/png)
2019-03-15 23:15 UTC, Noah Davis
Details
Shaded unmaximized Konsole window on top of a maximized Firefox window (72.41 KB, image/png)
2019-03-15 23:17 UTC, Noah Davis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Noah Davis 2019-03-15 23:15:59 UTC
Created attachment 118830 [details]
Shaded maximized Konsole window on top of a maximized Firefox window

SUMMARY
There is no visible difference between a shaded maximized window and the titlebar of the maximized window behind it. If all shaded windows were made to cast a shadow, the problem would be fixed.

STEPS TO REPRODUCE
1. Put one maximized window in front of another maximized window
2. Shade the top maximized window

OBSERVED RESULT
The tilebar of the shaded window in front is indistinguishable from the window behind it.

EXPECTED RESULT
There should be a visible difference between the titlebar of the shaded window and the titlebar of the window behind it.

SOFTWARE/OS VERSIONS
Linux Distribution: openSUSE Tumbleweed 20190314
KDE Plasma/KWin Version: 5.15.80 (git master)
KDE Frameworks Version: 5.57 (git master)
Qt Version: 5.12.0
Comment 1 Noah Davis 2019-03-15 23:17:42 UTC
Created attachment 118831 [details]
Shaded unmaximized Konsole window on top of a maximized Firefox window

This is how I think shaded maximized windows should look.
Comment 2 Nate Graham 2019-03-16 13:16:35 UTC
Do you have the titlebar gradient turned off, by any chance?
Comment 3 Noah Davis 2019-03-18 23:14:29 UTC
(In reply to Nate Graham from comment #2)
> Do you have the titlebar gradient turned off, by any chance?

Yes, but it makes no difference whether it is on or off.
Comment 4 Hugo Pereira Da Costa 2019-04-08 15:26:10 UTC
yes. The problem, is that the shadow is automatically turned off for maximized windows, whether they are shaded or not. 
As far as I know this turning off does not happen in breeze itself but libkdecoration2 (or kwin). It is the place where it should be fixed. 
Same problem also appears with oxygen.
Comment 5 Vlad Zahorodnii 2019-04-08 15:59:11 UTC
> It is the place where it should be fixed.

Visually, yeah, it would be great to draw shadows. (probably trivial change)

Though I think that shadows don't serve well for distinguishing shaded clients from normal clients. For what it's worth, initially I thought that screenshot in the second comment was expected result. It took me couple minutes to figure out what's wrong.

Counter example: decorations without shadows would still suffer from this problem.
Comment 6 Vlad Zahorodnii 2019-04-08 15:59:52 UTC
Also, I think decoration themes have to deal with this problem not window manager.
Comment 7 Vlad Zahorodnii 2019-04-08 16:01:59 UTC
> For what it's worth, initially I thought that screenshot in the second comment was expected result

Argh, please ignore this part. I got confused by shaded clients. It's pretty hard to distinguish them from normal clients. :D
Comment 8 Nate Graham 2019-04-08 16:08:52 UTC
Yes, the second screenshot depicts the desired appearance. :)
Comment 9 Vlad Zahorodnii 2019-04-08 16:25:49 UTC
My point was that it's hard to spot the difference between presented two cases (even if the shaded client has shadows).
Comment 10 Hugo Pereira Da Costa 2019-04-10 18:32:52 UTC
If it is a matter of adding the shadow on shaded clients whether maximized or not, this cannot be fixed in breeze. (the only thing breeze does about shadow is to pass some pixmaps to upstream libs (kdecoration2), which is where it is decided whether the shadow is rendered or not. Breeze has no say on this.
If now the proper fix is to additionally render the title bar of maximized shaded window differently from unmaximized and/or unshaded windows, disregarding whether the shadow is rendered or not, then indeed it is a breeze issue. 
So: where the bug belongs depends on how one wants to address it. 
If the solution is to render the shadow, then this is not a breeze bug.
Comment 11 Noah Davis 2019-04-27 01:39:31 UTC
(In reply to Hugo Pereira Da Costa from comment #10)
> If it is a matter of adding the shadow on shaded clients whether maximized
> or not, this cannot be fixed in breeze. (the only thing breeze does about
> shadow is to pass some pixmaps to upstream libs (kdecoration2), which is
> where it is decided whether the shadow is rendered or not. Breeze has no say
> on this.
> If now the proper fix is to additionally render the title bar of maximized
> shaded window differently from unmaximized and/or unshaded windows,
> disregarding whether the shadow is rendered or not, then indeed it is a
> breeze issue. 
> So: where the bug belongs depends on how one wants to address it. 
> If the solution is to render the shadow, then this is not a breeze bug.

I think the shadow should be rendered. If more is needed, then the shadow should be rendered and Breeze should be modified.
Comment 12 Michael D 2020-04-01 07:43:27 UTC
Are the windows drawn when the option is enabled to allow resizing of maximized windows? This makes the window border/frame visible for maximized windows, and think it should be enabled by default, but that is another issue.
Comment 13 Michael D 2020-04-01 07:44:28 UTC
Sorry, I mean, are the shadows drawn...