Created attachment 118785 [details] screenshot of pager applet SUMMARY The pager option to show desktop names doesn't actually show desktop names, on most setups, for lack of space (applet too small, font too big --> only "..." appears). STEPS TO REPRODUCE 1. Configure multiple virtual desktops 2. Add pager applet to panel 3. Configure pager 4. Click on "Display: Desktop Name" OBSERVED RESULT See screenshot attached. The names don't appear, only "..." Obviously the applet needs to be bigger for the names to appear. EXPECTED RESULT I can make the names appear if I make my panel HUGE (in terms of height). It would be much better if the names used a smaller font when there isn't enough room. And the applet could take more space horizontally. There doesn't seem to be a way to change the width of the applet, other than by increasing the height. How does that work? Constant aspect ratio or something? According to my wife who has good memory, this used to work better some versions ago, the text was visible on panels with a reasonable height. SOFTWARE/OS VERSIONS KDE Plasma Version: 5.15.0 KDE Frameworks Version: 5.57.0 Qt Version: 5.12.2
Git commit de1c1c93c88334fef78d0d568fce1ad6f118dc79 by Kai Uwe Broulik. Committed on 14/03/2019 at 09:37. Pushed by broulik into branch 'Plasma/5.15'. [Pager] Shrink label font size dynamically Tiny font is still more useful than "..." Differential Revision: https://phabricator.kde.org/D19751 M +4 -0 applets/pager/package/contents/ui/main.qml https://commits.kde.org/plasma-desktop/de1c1c93c88334fef78d0d568fce1ad6f118dc79
Your wife indeed has very good memory! Just checked the old sourcecode and it had a special case for this: // When containment is in this position [ie. horizontal] we are not limited by low width and we can // afford increasing width of applet to be able to display every name of desktops
Yep, that would still be useful to have ;) With your commit, my "KDE" desktop fits, but unfortunately other desktops have longer names and only show 1 or 2 letters followed by "..." :-)
(In reply to Kai Uwe Broulik from comment #2) > Your wife indeed has very good memory! Just checked the old sourcecode and > it had a special case for this: > > // When containment is in this position [ie. horizontal] we are not limited > by low width and we can > // afford increasing width of applet to be able to display every name of > desktops Yeah, it probably makes sense to bring that back if we can.
Fixed in plasma 5.15.4.
Patrick, can you point me to the fix? Are you referring to the commit in comment #1, or to something else that I can't find? That commit is far from enough to fix the bug.
I fixed the font shrinking but the previous "make the desktops wider to fit all labels" has not been reimplemented, re-opening.
My wife also complains that the desktops should be wider just so that the clicking area is big enough. Try a "2 columns 3 rows" layout with a normal-size panel, the clicking area is minuscule. Why can't the user choose the horizontal size of the pager, rather than relying on some (currently missing) automagic?
I'd much prefer an explicit user decision over automagic as well -- except we don't have an UX to resize panel widgets at the moment. (I'm not sure it's been said, but currently the pager representation just follows the screen aspect ratio.)
Ah, I see, because it represents the windows in the desktops. But IMHO that's a completely useless feature, it's too small. Wouldn't the best solution to have two alternative pagers? 1) the current one, which tries to present "thumbnails" of the desktops, and therefore has to respect aspect ratio. 2) one that would have full names, but no windows. I guess like in kicker? Less fancy, more usable. In practice I never EVER use the tiny representation of the open windows. But I'm happy for others to, this simply means two applets, and no need for manual resizing. Wouldn't that be simpler than trying to conciliate incompatible goals *and* implement a manual resizing feature?
Kai wrote a patch at Valencia he showed me, I'll let him update things here :)
https://phabricator.kde.org/D20796 and/or https://phabricator.kde.org/D20851 seems to have fixed it, I see full names on my laptop now.
Somehow I fail to see how those two patches could make any difference. I made a WIP patch on my laptop to fix it but I ran into some trouble. I'll put it on Phab so we can continue from there.
Indeed, if I revert plasma-desktop back to de1c1c93c (your commit) and reinstall plasma-desktop/applets/pager, I still see full desktop names, while I remember very well that I didn't use to, at the time. I didn't change my setup (font size, screen resolution, panel size, etc.) Either something changed in KF5 or in Qt5 then....
Somehow that patch I made a few weeks ago completely fell apart also. It almost worked but now it doesn't .. no point in putting it up right now. I'll see if I can come up with some workable solution again.
On my side, after a full reboot the desktop names are truncated again. Very weird. Current hypothesis, the plugging of an external monitor had something to do with it. To be confirmed later this week.
I confirm. The minute I plug an external monitor (so my desktop grows from 3840x2160 to 7680x2160, but the panel itself stays on the primary screen so no change there), the text on the pager's desktops changes to show the text fully.
Created attachment 121606 [details] screenshots with one and two monitors
Haha I see, that's because the new aspect ratio allows it :-)
*** Bug 430974 has been marked as a duplicate of this bug. ***
*** Bug 413686 has been marked as a duplicate of this bug. ***