Bug 405438 - old-style-connect: add support for converting QSignalSpy with PMF syntax
Summary: old-style-connect: add support for converting QSignalSpy with PMF syntax
Status: RESOLVED FIXED
Alias: None
Product: clazy
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Sergio Martins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-13 16:14 UTC by David Faure
Modified: 2019-04-04 08:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
testcase (2.75 KB, patch)
2019-03-13 16:14 UTC, David Faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Faure 2019-03-13 16:14:24 UTC
Created attachment 118777 [details]
testcase

Technically not a connect(), but... would it be possible for old-style-connect 
to port QSignalSpy to the PMF syntax?

My contribution is a patch that contains the unittest.
Comment 1 Sergio Martins 2019-04-04 07:50:59 UTC
Git commit 1253cc3b596416435ba7581598eeca8655b2d09f by Sergio Martins.
Committed on 04/04/2019 at 07:48.
Pushed by smartins into branch 'master'.

old-style-connect: Warn for QSignalSpy

Fixit yet to come

M  +16   -6    src/checks/level2/old-style-connect.cpp
M  +4    -1    src/checks/level2/old-style-connect.h
M  +4    -0    tests/old-style-connect/config.json
A  +29   -0    tests/old-style-connect/port_qsignalspy.cpp     [License: UNKNOWN]  *
A  +4    -0    tests/old-style-connect/port_qsignalspy.cpp.expected

The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


https://commits.kde.org/clazy/1253cc3b596416435ba7581598eeca8655b2d09f
Comment 2 Sergio Martins 2019-04-04 08:26:53 UTC
Git commit 6eba9241b2c1f31c9ffc5bc0e19805b05d3e0ca1 by Sergio Martins.
Committed on 04/04/2019 at 08:23.
Pushed by smartins into branch 'master'.

old-style-connect: Added fixit for QSignalSpy too

M  +9    -8    src/checks/level2/old-style-connect.cpp
M  +4    -1    src/checks/level2/old-style-connect.h
M  +5    -0    tests/old-style-connect/config.json
M  +2    -0    tests/old-style-connect/port_qsignalspy.cpp.expected
A  +29   -0    tests/old-style-connect/port_qsignalspy.cpp_fixed.cpp.expected

https://commits.kde.org/clazy/6eba9241b2c1f31c9ffc5bc0e19805b05d3e0ca1