Bug 405419 - Tajikistan Map Update
Summary: Tajikistan Map Update
Status: REPORTED
Alias: None
Product: kgeography
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Astals Cid
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-13 05:43 UTC by Victor Ibragimov
Modified: 2019-04-07 08:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
PNG images and Excel with names (145.22 KB, application/x-zip-compressed)
2019-03-13 05:43 UTC, Victor Ibragimov
Details
gimp_rgb (2.25 KB, application/x-zip-compressed)
2019-03-25 16:20 UTC, Victor Ibragimov
Details
Tajikistan Map (tajikistan.png and tajikistan.kgm) (13.01 KB, application/x-zip-compressed)
2019-03-26 14:35 UTC, Victor Ibragimov
Details
PNG in indexed mode (11.29 KB, application/x-zip-compressed)
2019-03-27 05:18 UTC, Victor Ibragimov
Details
Tajikistan districts map with borders 1 pixel thick (17.60 KB, image/png)
2019-03-30 20:43 UTC, Laurent G.
Details
Improved image (Tajikistan map); Mismatches (33.70 KB, application/x-zip-compressed)
2019-04-03 08:13 UTC, Victor Ibragimov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Ibragimov 2019-03-13 05:43:45 UTC
Created attachment 118766 [details]
PNG images and Excel with names

SUMMARY
The map of Tajikistan in KGeography is not complete and contains outdated data.

STEPS TO REPRODUCE
1. Add complete map of Tajikistan

Attached archive contains PNG images for the map and an Excel file with names of Regions, Districts, Cities and corresponding names of map images.
Comment 1 Albert Astals Cid 2019-03-13 21:42:21 UTC
https://en.wikipedia.org/wiki/Regions_of_Tajikistan seems to agree with what we have maybe what you want is in addition to the regions map to have a districts map?
Comment 2 Victor Ibragimov 2019-03-14 03:05:12 UTC
1)The information referenced to a Wikipedia page at https://en.wikipedia.org/wiki/Regions_of_Tajikistan is outdated and also needs to be updated.
"Qurghonteppa" city was remaned to "Bokhtar" city.
2) English version of region name "Вилояти Мухтори Кӯҳистони Бадахшон" was initially incorrectly translated from its original Tajik into English since "Gorno-Badakhshan" is a transliteration from its Russian version "Горно-Бадахшан.." It will be highly appreciated to update English version to "Kuhistoni Badakhshon Autonomous Region" to make it correct.

3)Yes, in addition to a 4 Regions Map that would be great to have a Districts Map, so students can explore more of Tajikistan and learn to know all those beautiful geographical names and their locations.
Comment 3 Albert Astals Cid 2019-03-17 23:27:46 UTC
Git commit 5e09450d2d9444776d27ed2e17c4b3d5e789e35b by Albert Astals Cid.
Committed on 17/03/2019 at 23:27.
Pushed by aacid into branch 'Applications/19.04'.

Qurghonteppa was renamed to Bokhtar on January 22, 2018

according to wikipedia

M  +1    -1    data/tajikistan.kgm

https://commits.kde.org/kgeography/5e09450d2d9444776d27ed2e17c4b3d5e789e35b
Comment 4 Albert Astals Cid 2019-03-17 23:27:46 UTC
Git commit f027f6331ea9b66d4ce54a4b12d37072df42358e by Albert Astals Cid.
Committed on 17/03/2019 at 23:27.
Pushed by aacid into branch 'Applications/19.04'.

Seems Kuhistani Badakhshan is a better name than Gorno-Badakhshan

wikipedia uses both but uses Kuhistani Badakhshan as the first name so
let's go with that one

M  +1    -1    data/tajikistan.kgm

https://commits.kde.org/kgeography/f027f6331ea9b66d4ce54a4b12d37072df42358e
Comment 5 Albert Astals Cid 2019-03-17 23:28:50 UTC
I've handled the two "renamings", having a new map with all the districts is something i don't really have time to work on at this point.

Maybe you can have a look? It's not very hard to do a kgeography map.
Comment 6 Laurent G. 2019-03-18 20:09:38 UTC
It used to be easy.
Don't know if my plugins to the Gimp still work.
Source code for the C plugin vanished from the net when gna.org disappeared, years ago.
I looked at hte joined archive, the png for the districts looks like the frontiers are just 1 pixel thick. So the C-plugin might be optional.
I'll have to check the python plugin, for coloring nicely, when my chronovores let me some times.
Comment 7 Victor Ibragimov 2019-03-25 16:20:49 UTC
Created attachment 119025 [details]
gimp_rgb

Could you please, check if the generated gimp rgb and tajikistan.kgm are ok, so I can start to color the regions - there are over 60 images to edit.
Comment 8 Albert Astals Cid 2019-03-25 23:04:39 UTC
What do you mean there are over 60 images to edit? It should just be one map, no?
Comment 9 Victor Ibragimov 2019-03-26 14:35:11 UTC
Created attachment 119055 [details]
Tajikistan Map (tajikistan.png and tajikistan.kgm)

Yes, there is just one image for the Map. Could you please, help to re-check the colors and draw 1px black line of border for the regions, districts and cities.
Comment 10 Albert Astals Cid 2019-03-26 20:58:00 UTC
$ ./tools/colorchecker.py data/tajikistan.kgm 
Processing data/tajikistan.kgm
Error: The PNG file should be in indexed color mode

after using the gimp to convert it to indexed mode

$ ./tools/colorchecker.py data/tajikistan.kgm 
Processing data/tajikistan.kgm
Error: The pixel (0 ,0) has color rgba 204,204,204,255 that is not defined in the kgm file
Error: The pixel (119 ,304) has color rgba 126,186,130,255 that is not defined in the kgm file
Error: The pixel (119 ,305) has color rgba 117,178,130,255 that is not defined in the kgm file
Error: The pixel (119 ,306) has color rgba 126,187,130,255 that is not defined in the kgm file
Error: The pixel (166 ,272) has color rgba 129,189,189,255 that is not defined in the kgm file
Error: The pixel (167 ,272) has color rgba 129,160,189,255 that is not defined in the kgm file
Error: The pixel (167 ,273) has color rgba 126,159,185,255 that is not defined in the kgm file
Error: The pixel (168 ,406) has color rgba 126,243,130,255 that is not defined in the kgm file
Error: The pixel (168 ,407) has color rgba 117,225,130,255 that is not defined in the kgm file
Error: The pixel (183 ,294) has color rgba 124,158,183,255 that is not defined in the kgm file
Error: The pixel (184 ,294) has color rgba 118,157,177,255 that is not defined in the kgm file
Error: The pixel (185 ,294) has color rgba 122,158,181,255 that is not defined in the kgm file
Error: The pixel (187 ,106) has color rgba 202,203,203,255 that is not defined in the kgm file
Error: The pixel (187 ,107) has color rgba 194,198,197,255 that is not defined in the kgm file
Error: The pixel (187 ,109) has color rgba 200,202,202,255 that is not defined in the kgm file
Error: The pixel (230 ,108) has color rgba 185,131,130,255 that is not defined in the kgm file
Error: The pixel (291 ,37) has color rgba 159,248,248,255 that is not defined in the kgm file
Error: The pixel (295 ,45) has color rgba 156,245,245,255 that is not defined in the kgm file
Error: The pixel (547 ,231) has color rgba 155,215,130,255 that is not defined in the kgm file
Error: The pixel (547 ,232) has color rgba 159,219,130,255 that is not defined in the kgm file
Error: The pixel (548 ,232) has color rgba 157,217,130,255 that is not defined in the kgm file
Comment 11 Victor Ibragimov 2019-03-27 05:18:38 UTC
Created attachment 119072 [details]
PNG in indexed mode

Could you please, re-check it again. It is now in indexed mode.
The "Not Tajikistan" color is "cccccc" - I suggest it should be added to tajikistan.kgm file as I colored this area manually.
Comment 12 Victor Ibragimov 2019-03-27 05:20:17 UTC
(In reply to Laurent G. from comment #6)
> It used to be easy.
> Don't know if my plugins to the Gimp still work.
> Source code for the C plugin vanished from the net when gna.org disappeared,
> years ago.
> I looked at hte joined archive, the png for the districts looks like the
> frontiers are just 1 pixel thick. So the C-plugin might be optional.
> I'll have to check the python plugin, for coloring nicely, when my
> chronovores let me some times.

Could you please, help to draw the frontiers with C-plugin.
Comment 13 Albert Astals Cid 2019-03-27 22:42:20 UTC
(In reply to Victor Ibragimov from comment #11)
> Created attachment 119072 [details]
> PNG in indexed mode
> 
> Could you please, re-check it again. It is now in indexed mode.
> The "Not Tajikistan" color is "cccccc" - I suggest it should be added to
> tajikistan.kgm file as I colored this area manually.

I'm getting the exact same errors reported in comment #10
Comment 14 Laurent G. 2019-03-28 20:59:01 UTC
Good news, I found back my sources of the C plugin, dated from the 2008-06-08 ...
Still have little time to check it is still functional.
Stay tuned, but patient.
Comment 15 Victor Ibragimov 2019-03-29 06:03:35 UTC
Great news about the C-plugin recovery! I suggest that the apply of the C-plugin will fix all of the above coloring issues with the image (map).
Comment 16 Laurent G. 2019-03-30 20:43:54 UTC
Created attachment 119165 [details]
Tajikistan districts map with borders 1 pixel thick

I changed the gray for some orange because my plugin does not treat grays like other colos
Comment 17 Laurent G. 2019-03-30 20:57:18 UTC
None of the txt file make sense to me.
Region information is repeated ad nauseum uselessly.
The closest to useful is the tajikistan.txt where we could get the district names by removing text up to and including the semicolon and then the uselessly repetitive District, and Disrtict.
Comment 18 Laurent G. 2019-03-30 21:20:54 UTC
In the png you sent, I notices 86 different colors. To which I added one for the black borders.
But in the tajikistan, I can only find 67 lines.
Could you check where the mismatch lies ? Thanks in advance.
Comment 19 Victor Ibragimov 2019-04-03 08:13:30 UTC
Created attachment 119221 [details]
Improved image (Tajikistan map); Mismatches

Could you please, find and re-check the attached zip file with fixed mismatches of colors in Tajikistan map. In the attached file you will find:
1) tajikistan.png (improved image- there should be 65 colors now except of black border line and Not Tajikistan gray color) 
2) mismatch_tajikistan.png (just for your reference, if needed to see the fixed mismatches)
3) Tajikistan_Map_Colors.txt (to re-check with tajikistan.kgm colors) Tab delimited
Comment 20 Laurent G. 2019-04-07 08:09:03 UTC
I updated http://lauranger.free.fr/kgeomapp/ for dead links.
One can found there links to the plugins sources, as well as some other maps.