Bug 405365 - PPC64, function _get_maxmin_fp_NaN() doesn't handle QNaN, SNaN case correctly
Summary: PPC64, function _get_maxmin_fp_NaN() doesn't handle QNaN, SNaN case correctly
Status: CLOSED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (other bugs)
Version First Reported In: 3.15 SVN
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-11 19:21 UTC by Carl Love
Modified: 2019-03-25 14:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
fix the _get_maxmin_fp_NAN function (2.85 KB, patch)
2019-03-22 17:35 UTC, Carl Love 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Love 2019-03-11 19:21:02 UTC 
The _get_maxmin_fp_NaN() function is used in instructions xvmaxsp, xvminsp, xvmindp, xvmaxdp.  The case where srcA is QNaN and src is SNaN returns SNaN.  However, in this case the HW sets the result to QNaN.
Comment 1 Carl Love 2019-03-22 17:35:12 UTC 
Created attachment 118974 [details]
fix the _get_maxmin_fp_NAN function

The attached patch was committed to fix the issue.

commit e9986500957ae53ef6374e86938188bca4d1c6df
Author: Carl Love <carll@us.ibm.com>
Date:   Fri Mar 22 12:32:29 2019 -0500
Comment 2 Carl Love 2019-03-25 14:47:27 UTC 
No regressions found by automated regression testing.  Closing.