Bug 405144 - Hamburger menu and settings window show fonts badly rendered when fractional display scaling is used
Summary: Hamburger menu and settings window show fonts badly rendered when fractional ...
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on: 405541
Blocks:
  Show dependency treegraph
 
Reported: 2019-03-06 16:01 UTC by Patrick Silva
Modified: 2019-08-13 18:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
hamburger menu (46.10 KB, image/png)
2019-03-06 16:01 UTC, Patrick Silva
Details
elisa settings (42.42 KB, image/png)
2019-03-06 16:01 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-03-06 16:01:12 UTC
Created attachment 118596 [details]
hamburger menu

SUMMARY
I have nightly build of elisa installed.

STEPS TO REPRODUCE
1. open system settings > display and monitor > scale display and set display scaling factor to 1.2
2. restart plasma
3. open elisa, click hamburger menu > Configure Elisa...

OBSERVED RESULT
hamburger menu and settings window show fonts badly rendered.
See the screenshots please.

EXPECTED RESULT
good font rendering.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.2
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1
Comment 1 Patrick Silva 2019-03-06 16:01:33 UTC
Created attachment 118597 [details]
elisa settings
Comment 2 Nate Graham 2019-03-16 21:45:57 UTC
This is because they use QtQuickControls 1, which always looks bad with fractional scale factors. I tried my hand at porting these parts of the UI to use QQC2, and that fixes the problem. But I ran into an issue: QQC2 menu items are much more difficult to assign keyboard shortcuts to (Bug 405541).
Comment 3 Alexander Stippich 2019-06-30 06:44:00 UTC
Git commit 39052265e4c4d4249f7de7136b8655a240f1e9df by Alexander Stippich.
Committed on 30/06/2019 at 06:43.
Pushed by astippich into branch 'master'.

Port elisa kcm to qqc2

Summary:
Port to the local file kcm to qqc2, no visual and functional change

Reviewers: mgallien, ngraham

Reviewed By: mgallien, ngraham

Subscribers: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D21920

M  +14   -15   src/localFileConfiguration/package/contents/ui/main.qml

https://commits.kde.org/elisa/39052265e4c4d4249f7de7136b8655a240f1e9df
Comment 4 Alexander Stippich 2019-08-13 18:31:49 UTC
Git commit c7939481101eec243acd7b5538807e27846a194d by Alexander Stippich.
Committed on 13/08/2019 at 18:31.
Pushed by astippich into branch 'master'.

Port the application menu to qqc2

Summary:
Move to an item-based qqc2 implementation.
The menu is the last blocker for a full qqc2 Elisa!

This must not land until the corresponding patch
for the qqc2 desktop style is landed released

Depends on D21944
Depends on D22011

Test Plan: menu works as before

Reviewers: mgallien, ngraham

Reviewed By: mgallien, ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D21943

M  +1    -1    CMakeLists.txt
M  +17   -25   src/qml/ApplicationMenu.qml

https://commits.kde.org/elisa/c7939481101eec243acd7b5538807e27846a194d