Bug 404941 - [Regression] Konsole closes search-box when it's unfocused upon pressing Esc
Summary: [Regression] Konsole closes search-box when it's unfocused upon pressing Esc
Status: RESOLVED INTENTIONAL
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 18.12.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-01 12:51 UTC by Konstantin Kharlamov
Modified: 2019-03-06 21:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Kharlamov 2019-03-01 12:51:38 UTC
SUMMARY

Upon working in terminal, one often needs to press Escape to interact with terminal applications. Until recently that didn't conflict with Search-Box because to dismiss the later it needs to get focused.

But now the box is always dismissed upon pressing Escape.

STEPS TO REPRODUCE
1. Press Ctrl+Shif+f for the box to appear
2. Click with mouse the terminal to unfocus the box
3. Press Escape

OBSERVED RESULT

The search-box disappears

EXPECTED RESULT

Nothing happens.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: i3wm is used, not Plasma
KDE Frameworks Version: 5.54.0
Qt Version: 5.12.0
Konsole Version: 18.12.1
Comment 1 Nate Graham 2019-03-02 13:41:40 UTC
I believe this is intentional. Before, we had it such that you needed to focus the search field to have the escape key close the search panel, and we got a lot of negative feedback about that.

Just hit ctrl+shift+f to re-open the search bar when you need it. It'll even remember your last search term. :)
Comment 2 Konstantin Kharlamov 2019-03-02 15:34:14 UTC
(In reply to Nate Graham from comment #1)
> Just hit ctrl+shift+f to re-open the search bar when you need it. It'll even
> remember your last search term. :)

The problem is that one can't just hit the hotkey, and continue working. Because now you need to find the mouse, click the terminal to unfocus the box, and only then you can continue working.

> I believe this is intentional. Before, we had it such that you needed to
> focus the search field to have the escape key close the search panel, and we
> got a lot of negative feedback about that.

I see the other workflow, but if you compare them, it clearly became worse:

Working around annoyance (i.e. having highlight all the time) in workflow you mentioned:
    1. Hit the ctrl+shift+f to focus search box
    2. Press escape to dismiss
    3. Continue typing

Working around annoyance (i.e. not having highlight all the time) in workflow that changes broke:
    1. Hit the ctrl+shift+f to focus search box
    2. Find the mouse on the table, and press terminal to unfocus the search-box
    3. Move hands back to keyboard
    4. Continue typing

Can perhaps this change be made optional? Preferably even opt-in, because I imagine the workflow that changes broke must be pretty popular. One example of the workflow is when you use a terminal tab mostly for building, and it's hard without manual highlight to understand where C++ code has a problem breaking the build¹. Another one is when you research some problem, you do a lot of actions in terminal such as checking out git revisions, opening logs in vim, grepping stuff, etc, and having highlight for some keywords speeds up this process.

The other workflow… Well, I might have had a few times when I didn't need search box, and I wanted to dismiss it, but doing that so much quicker, and so much less annoyance comparing to what it is now, it's just 2 shortcus presses instead of 1.

1: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89326
Comment 3 Konstantin Kharlamov 2019-03-04 22:06:24 UTC
Given above comment, can I reopen the issue?
Comment 4 Nate Graham 2019-03-06 21:28:07 UTC
I'm not sure I understand. There's no need to use the mouse at all. Am I understanding that you want the search bar to be open all the time? Sorry if I'm being thick here. :)