Bug 404901 - google auth dialog => firefox google auth window not closed
Summary: google auth dialog => firefox google auth window not closed
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Google (show other bugs)
Version: 6.0.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-28 10:36 UTC by Philippe ROUBACH
Modified: 2020-01-18 21:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0


Attachments
last google auth dialog window (42.17 KB, image/png)
2019-02-28 10:36 UTC, Philippe ROUBACH
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe ROUBACH 2019-02-28 10:36:28 UTC
Created attachment 118431 [details]
last google auth dialog window

SUMMARY


STEPS TO REPRODUCE
1. try to export a photo to google photo
2. a google auth dialog is launch
3. digikam is well connected to google photo 

OBSERVED RESULT

the last firefox dialog window is not closed
EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2019-02-28 13:02:15 UTC
We can start Firefox and open a page, but not close it anymore. If QWebEngine is available on all platforms, it will be possible if we use the internal browser. This is not a bug for me.

Maik
Comment 2 caulier.gilles 2020-01-15 08:47:03 UTC
Today, next digiKam 7.0.0 beta2 64 bits pre-release AppImage bundle will be
published with last Qt5.14 and QtWebEngine by default (instead QtWebkit).

Please test and give us a feedback to see if problem remain on your computer.

https://files.kde.org/digikam/

Thanks in advance

Giles Caulier
Comment 3 Philippe ROUBACH 2020-01-15 17:53:30 UTC
7.00 beta 2

problem still there
Comment 4 Maik Qualmann 2020-01-15 21:00:09 UTC
It's not a problem, it's normal behavior ((:-)) We can also use our internal browser for Google. In principle, I would have to change the callback address at Google, only that would make all older versions of the plugin inoperative. Let's see if I can trick it.

Maik
Comment 5 Maik Qualmann 2020-01-18 21:36:45 UTC
Git commit 4f6f30f5d2c370bd9181310fe55bafa435ad40ff by Maik Qualmann.
Committed on 18/01/2020 at 21:35.
Pushed by mqualmann into branch 'master'.

use internal web browser to close the window
At the moment we are still using the current callback
address to get compatible with older plugin versions.
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +0    -1    core/dplugins/generic/webservices/flickr/CMakeLists.txt
M  +0    -1    core/dplugins/generic/webservices/flickr/flickrtalker.cpp
M  +66   -35   core/dplugins/generic/webservices/google/gstalkerbase.cpp
M  +3    -2    core/dplugins/generic/webservices/google/gstalkerbase.h
M  +0    -1    core/dplugins/generic/webservices/onedrive/CMakeLists.txt
M  +0    -1    core/dplugins/generic/webservices/pinterest/CMakeLists.txt

https://invent.kde.org/kde/digikam/commit/4f6f30f5d2c370bd9181310fe55bafa435ad40ff