Created attachment 118366 [details] Discover: before 49856625cc4fb7136099ce69bfb92d99a5bca480 makes Discover look bad by default. See attached screenshots. Semantically the change seems wrong. That almost-white color is supposed to be used for the background in bounded content views like lists and grids. It's not the correct default background color for everything, and it seems especially wrong when used under a cards list view.
Created attachment 118367 [details] Discover: after
kirigami pages used to not have backgrounds with the asked colors by default and that was wrong. there, just seems that the flathub page is asking for the view instead of the window colorset (imo the other page looks better now.. even tough if one really wants the old behavior, that can be done) in general, all pages which are an item view (except if the items are cards, like the flathub page) should have the view colorset (white bg) all pages that either are not an itemview or the items are cards should use the window color set (gray background)
Ok, let's make cards views get the window colorset by default, then.
Git commit 094c9d947e17768397aca8572865799f0650f594 by Nate Graham. Committed on 16/03/2019 at 20:41. Pushed by ngraham into branch 'Plasma/5.15'. Restore proper background color on list and sources pages Summary: Kirigami changed the defaults in 49856625cc4fb7136099ce69bfb92d99a5bca480, so we have to adapt in Discover. Test Plan: {F6687104} Reviewers: apol, #discover_software_store Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D19712 M +6 -0 discover/qml/ApplicationsListPage.qml M +6 -0 discover/qml/BrowsingPage.qml M +6 -0 discover/qml/SourcesPage.qml https://commits.kde.org/discover/094c9d947e17768397aca8572865799f0650f594
Baaaaaaasically a dupe of Bug 421574. *** This bug has been marked as a duplicate of bug 421574 ***