Bug 404755 - SwipeListItem: label can overlap action icons; should be elided instead
Summary: SwipeListItem: label can overlap action icons; should be elided instead
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.15.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-24 01:28 UTC by Patrick Silva
Modified: 2019-03-01 05:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.3


Attachments
screenshot (143.62 KB, image/png)
2019-02-24 01:28 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-02-24 01:28:52 UTC
Created attachment 118327 [details]
screenshot

SUMMARY
I have the repo of Firefox flatpak on my system.
https://firefox-flatpak.mojefedora.cz/
When I open "Sources" page and click any filter icon, repo name overlaps the icons. See the screenshot.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.1
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1
Comment 1 Aleix Pol 2019-02-27 21:02:40 UTC
This is not a bug in Kirigami, as it's not necessarily a Label over there.
The problem is that we are using rich text, which can't be elided :'(
Comment 2 Aleix Pol 2019-02-27 21:15:51 UTC
Turns out it still need changes in kirigami: https://phabricator.kde.org/D19399
Comment 3 Aleix Pol 2019-02-27 21:18:00 UTC
Git commit 1b569001aac76d1a733a7ed45cf249da18c10a7a by Aleix Pol.
Committed on 27/02/2019 at 21:15.
Pushed by apol into branch 'Plasma/5.15'.

Set the sources label to  textFormat: Text.StyledText

This way it can be elided

M  +1    -0    discover/qml/SourcesPage.qml

https://commits.kde.org/discover/1b569001aac76d1a733a7ed45cf249da18c10a7a
Comment 4 Aleix Pol 2019-02-28 20:39:28 UTC
Git commit cd5bae6d3df0c7f736aa752943a71b83276eec41 by Aleix Pol.
Committed on 28/02/2019 at 20:37.
Pushed by apol into branch 'master'.

SwipeListItem: make space for the actions when !supportsMouseEvents

Summary:
They will be shown all the time and we don't want the content over it

Reviewers: #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D19399

M  +1    -1    src/controls/templates/SwipeListItem.qml
A  +51   -0    tests/swipeListItemTest.qml     [License: LGPL (v2+)]

https://commits.kde.org/kirigami/cd5bae6d3df0c7f736aa752943a71b83276eec41