Bug 404603 - Text is cut off in "Update" page when some update is unselected and the description of some update is open
Summary: Text is cut off in "Update" page when some update is unselected and the descr...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Flatpak Backend (show other bugs)
Version: 5.15.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-20 15:34 UTC by Patrick Silva
Modified: 2019-02-21 20:04 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/discover/5d254de6fa4f1c7608f3b01a5f582b3d13ef2760
Version Fixed In: 5.16

Attachments
screenshot (354.38 KB, image/png)
2019-02-20 15:34 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-02-20 15:34:53 UTC 
Created attachment 118215 [details]
screenshot

STEPS TO REPRODUCE
1. open Discover while updates are available
2. click "Update" in the side bar, unselect some update available
3. click some update available, click "More info" button to open its description

OBSERVED RESULT
"unselected updates" ("atualizações não selecionadas" in my pt-br language) text is cut off. See the screenshot.

EXPECTED RESULT
text is entirely readable

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.1
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1
Comment 1 Nate Graham 2019-02-20 20:28:57 UTC 
Here's a patch: https://phabricator.kde.org/D19192
Comment 2 Nate Graham 2019-02-21 20:04:09 UTC 
Git commit 5d254de6fa4f1c7608f3b01a5f582b3d13ef2760 by Nate Graham.
Committed on 21/02/2019 at 20:04.
Pushed by ngraham into branch 'master'.

[Updates page] Improve selected/unselected explanation view

Summary:
Improve the clarity of the information that's being displayed, reduce string length
so that wordy languages don't get anything cut off, and elide properly just in case
they do.
FIXED-IN: 5.16

Test Plan:
All updates selected: {F6626922, size=full}
Some Updates selected: {F6626923, size=full}
No updates selected: {F6626925, size=full}

Reviewers: #vdg, #discover_software_store, apol

Reviewed By: #discover_software_store, apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19192

M  +2    -15   discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/5d254de6fa4f1c7608f3b01a5f582b3d13ef2760