Bug 404497 - QQC2 Combobox's pop-up does not fully respect the color scheme
Summary: QQC2 Combobox's pop-up does not fully respect the color scheme
Status: RESOLVED NOT A BUG
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.55.0
Platform: Mageia RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-17 21:50 UTC by JanKusanagi
Modified: 2019-02-18 14:35 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Configure Desktop dialog is very hard to use with a dark color scheme (78.03 KB, image/png)
2019-02-17 21:50 UTC, JanKusanagi
Details
Plasma 5.14 was decent in this regard (not perfect, bud good enough) (46.26 KB, image/png)
2019-02-17 21:51 UTC, JanKusanagi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description JanKusanagi 2019-02-17 21:50:37 UTC
Created attachment 118167 [details]
Configure Desktop dialog is very hard to use with a dark color scheme

SUMMARY

Comboboxes used since Plasma 5.15.0 in places like the Desktop Settings dialog (which used to be OK), are now unreadable while using a dark color scheme.
Apparently the affected dialogs have been ported to QQC2.

I'm attaching a screenshot that says it all.

Cheers!


STEPS TO REPRODUCE
1. Go to System Settings → Colors, and select something built-in, but dark, like Breeze Dark.
2. Right-click the desktop and select Configure Desktop.
3. Click any of the readily available comboboxes there.

OBSERVED RESULT
Only currently selected item is readable, the rest are white text on white background.

EXPECTED RESULT
Background should be one of the dark tones from the color scheme, designated for  one of the several kinds of backgrounds.


SOFTWARE/OS VERSIONS
Operating System: Mageia 7
KDE Plasma Version: 5.15.0
Qt Version: 5.12.1
KDE Frameworks Version: 5.55.0

ADDITIONAL INFORMATION
Problem is not there with Plasma 5.15 and same version of KF5, but that makes sense since this dialog didn't use QQC2 in 5.14, apparently.
Comment 1 JanKusanagi 2019-02-17 21:51:47 UTC
Created attachment 118168 [details]
Plasma 5.14 was decent in this regard (not perfect, bud good enough)

Also attaching comparison to Plasma 5.14.5
Comment 2 Nate Graham 2019-02-17 21:55:34 UTC
This layout was ported to QQC2 in Plasma 5.15 (https://cgit.kde.org/plasma-desktop.git/commit/?id=c2640f83f1077365cd7f87ca2adbfbfb12cf4da7), so it seems like an issue with the QQC2 style.
Comment 3 JanKusanagi 2019-02-18 14:29:31 UTC
OK, I'm an idiot xD

Turns out there was a missing dependency on qqc2-desktop-style, so that wasn't being installed. An updated plasma-desktop package depending on qqc2-desktop-style fixed the unreadable comboboxes issue, and actually made many other things look much better. Comboboxes are actually better than they were in Plasma 5.14 =)

Maybe it would be good if this kind of thing could be a little less silent when failing to load needed components.


So I guess we can close this non-bug. Sorry for the noise!
Comment 4 Nate Graham 2019-02-18 14:31:51 UTC
> there was a missing dependency on qqc2-desktop-style
I hope you've reported this to your distro! :)
Comment 5 JanKusanagi 2019-02-18 14:35:30 UTC
(In reply to Nate Graham from comment #4)
> > there was a missing dependency on qqc2-desktop-style
> I hope you've reported this to your distro! :)

It was actually Mageia's packagers who found that and asked me to check the updates, so, yeah, kinda =)