Bug 404477 - Binary file causes Desktop freeze
Summary: Binary file causes Desktop freeze
Status: CONFIRMED
Alias: None
Product: kdiff3
Classification: Applications
Component: application (show other bugs)
Version: 1.7.90
Platform: Fedora RPMs Linux
: NOR crash
Target Milestone: ---
Assignee: michael
URL:
Keywords:
Depends on:
Blocks: 410008
  Show dependency treegraph
 
Reported: 2019-02-17 13:49 UTC by Attila
Modified: 2022-09-29 20:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Pop-up "Some input characters ..." (116.59 KB, image/png)
2022-09-28 06:50 UTC, Attila
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Attila 2019-02-17 13:49:20 UTC
SUMMARY

Drag and drop a binary file (png, pdf, ...) to "A" or "B" causes Desktop freeze.

STEPS TO REPRODUCE
1. Open KDiff3
2. Choose a binary file in the open dialog or drop it to "A" or "B"

OBSERVED RESULT

Desktop freeze, hard drive is "busy".

EXPECTED RESULT

The desktop should not freeze.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3
Comment 1 michael 2019-05-12 17:32:16 UTC
Working the speed issues now. This will require some major changes to the file comparison routine. Currently kdiff3 runs three loops through the entire file and copies three complete copies in memory. The changes will be master only do to the extant of the work required.
Comment 2 Justin Zobel 2022-09-25 22:38:32 UTC
Thank you for reporting this crash in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the crash with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 3 Attila 2022-09-28 06:49:59 UTC
(In reply to Justin Zobel from comment #2)
> Thank you for reporting this crash in KDE software. As it has been a while
> since this issue was reported, can we please ask you to see if you can
> reproduce the crash with a recent software version?
> 
> If you can reproduce the issue, please change the status to "CONFIRMED" when
> replying. Thank you!

Hi,

thank you for your reply.
The good news is that I can drag and drop binary files to "A" and "B" without a crash.
The bad news is that KDiff3 doesn't compare binary files. A Pop-up window come up instead with "Some input characters ..." (see attached file).
So I set the status to "CONFIRMED". If you don't agree with the status "CONFIRMED", please change again.
Comment 4 Attila 2022-09-28 06:50:53 UTC
Created attachment 152484 [details]
Pop-up "Some input characters ..."
Comment 5 michael 2022-09-29 20:33:16 UTC
It very likely does still occur if binaries were to be allowed going try enabling binaries on my machine to see what's breaking. Current versions block binary files to avoid trigger this and other possible issues. The core of kdiff3 generally assumes its working with text files and does not always play nice with binary files.