Git commit 3223fc1209ca6e06f6bdc34ba6858213e7287dd2 by Volker Krause.
Committed on 09/03/2019 at 13:12.
Pushed by vkrause into branch 'master'.

Support SNCF confirmation emails too

M  +48   -1    src/extractors/sncf.js
M  +6    -0    src/extractors/sncf.json

https://commits.kde.org/kitinerary/3223fc1209ca6e06f6bdc34ba6858213e7287dd2

thanks

can we expect this fix in kde app 18.12.3 ?

No, KDE Applications 18.12.3 were already released on 7th.

Created attachment 119994 [details]
sncf TER confirmation email

it is compliant with "TGV" confirmation see "sncf confirmation email"

it is not compliant with a "TER" confirmation email. see "sncf TER confirmation email"

i forget this

Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.57.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION
kontact 5.11.1
itinerary 19.04.1

Git commit ac3f622b157a9a395898d231ff4dcf9a3ce8293f by Volker Krause.
Committed on 12/05/2019 at 09:17.
Pushed by vkrause into branch 'Applications/19.04'.

PNR is optional in SNCF booking confirmations

Non-TGV tickets don't have that, so don't fail if it's not present.

M  +4    -2    src/extractors/sncf.js

https://commits.kde.org/kitinerary/ac3f622b157a9a395898d231ff4dcf9a3ce8293f

thanks

since update of kde app 19.04.1 and to kde frameworks 5.58

itinerary works no more with kmail neither with a tgv confirmation nor a TER confirmation.

i made an error for tgv confirmation it's ok.

for TER confirmation it's not ok.

Created attachment 120151 [details]
another TER confirmation mail, same as the first except date

The fix for TER bookings didn't make it into 19.04.1, that was already tagged at the time of that change, sorry for not making that explicit. So 19.04.1 will have the same issue, only 19.04.2 or newer work.

Here's the extractor result of your latest test case as proof ;-)

[
    {
        "@context": "http://schema.org",
        "@type": "TrainReservation",
        "reservationFor": {
            "@type": "TrainTrip",
            "arrivalStation": {
                "@type": "TrainStation",
                "name": "PESSAC"
            },
            "arrivalTime": "2019-05-18T09:13:00",
            "departureDay": "2019-05-18",
            "departureStation": {
                "@type": "TrainStation",
                "name": "CAUDERAN MERIGNAC"
            },
            "departureTime": "2019-05-18T09:06:00",
            "trainName": "TER",
            "trainNumber": "866178"
        }
    },
    {
        "@context": "http://schema.org",
        "@type": "TrainReservation",
        "reservationFor": {
            "@type": "TrainTrip",
            "arrivalStation": {
                "@type": "TrainStation",
                "name": "ARCACHON"
            },
            "arrivalTime": "2019-05-18T10:28:00",
            "departureDay": "2019-05-18",
            "departureStation": {
                "@type": "TrainStation",
                "name": "PESSAC"
            },
            "departureTime": "2019-05-18T09:41:00",
            "trainName": "TER",
            "trainNumber": "866315"
        }
    },
    {
        "@context": "http://schema.org",
        "@type": "TrainReservation",
        "reservationFor": {
            "@type": "TrainTrip",
            "arrivalStation": {
                "@type": "TrainStation",
                "name": "PESSAC"
            },
            "arrivalTime": "2019-05-18T17:18:00",
            "departureDay": "2019-05-18",
            "departureStation": {
                "@type": "TrainStation",
                "name": "ARCACHON"
            },
            "departureTime": "2019-05-18T16:33:00",
            "trainName": "TER",
            "trainNumber": "866346"
        }
    },
    {
        "@context": "http://schema.org",
        "@type": "TrainReservation",
        "reservationFor": {
            "@type": "TrainTrip",
            "arrivalStation": {
                "@type": "TrainStation",
                "name": "CAUDERAN MERIGNAC"
            },
            "arrivalTime": "2019-05-18T18:07:00",
            "departureDay": "2019-05-18",
            "departureStation": {
                "@type": "TrainStation",
                "name": "PESSAC"
            },
            "departureTime": "2019-05-18T18:01:00",
            "trainName": "TER",
            "trainNumber": "866193"
        }
    }
]

Created attachment 120788 [details]
OUIGO sncf confirmation mail

itinerary not compliant with OUIGO sncf confirmation mail

Thank you! The entire OUIGO booking workflow is indeed not supported yet (this is the first sample we got for it).

Created attachment 121767 [details]
ouigo, bordeaux-paris,mail, ticket is now available

OUIGO ticket

this is not a confirmation mail but a mail to notify that the ticket is now available for android app or for printing.

Created attachment 122554 [details]
Confirmation pour votre voyage CAUDERAN MERIGNAC - ARCACHON, aller le 08 sept., retour le 08 sept.

Itinerary decodes no more SNCF TER confirmation mail.

(In reply to Philippe ROUBACH from comment #15)
> Created attachment 122554 [details]
> Confirmation pour votre voyage CAUDERAN MERIGNAC - ARCACHON, aller le 08
> sept., retour le 08 sept.
> 
> Itinerary decodes no more SNCF TER confirmation mail.

i forgot:

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: openSuse leap 15.41
(available in About System)
KDE Plasma Version: 5.16.5.0
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.1

ADDITIONAL INFORMATION
kontact 5.12.1
itinerary 19.08.1

Git commit 1bec3fd915adfc63c55d9b9e478718b6aaaa23fd by Volker Krause.
Committed on 19/09/2019 at 17:03.
Pushed by vkrause into branch 'Applications/19.08'.

Fix date parsing in SNCF confirmation emails

M  +2    -2    src/extractors/sncf.js

https://commits.kde.org/kitinerary/1bec3fd915adfc63c55d9b9e478718b6aaaa23fd

Created attachment 123144 [details]
confirmation mail of "La fourchette" android app

I am not sure itinerary takes care of this sort of mail. But when I saw the itinerary part in this mail I found it is very handy. Perhaps an enhancement ?


All runs well but not for adding this event "a restaurant reservation"

The beginning is good "12 h" but the end is not good "23 h 59". It must be "14 h"

https://play.google.com/store/apps/details?id=com.lafourchette.lafourchette

Interesting! This seems to show up correctly here in KMail and in KDE Itinerary, however I don't see the end time shown anywhere (and there is none specified in the email). Where did it show 23h59 for you?

[
    {
        "@context": "http://schema.org",
        "@type": "FoodEstablishmentReservation",
        "partySize": 2,
        "reservationFor": {
            "@type": "FoodEstablishment",
            "address": {
                "@type": "PostalAddress",
                "addressCountry": "FR",
                "addressLocality": "Bordeaux",
                "postalCode": "33300",
                "streetAddress": "8 Quai de Bacalan"
            },
            "name": "La Brasserie des Chartrons"
        },
        "reservationNumber": "2124052552",
        "startTime": {
            "@type": "QDateTime",
            "@value": "2019-10-15T12:00:00+02:00",
            "timezone": "Europe/Paris"
        },
        "underName": {
            "@type": "Person",
            "name": "Philippe ROUBACH"
        }
    }
]

a hypothesis:

when you reserve a restaurant you reserve for an hour not a duration then there is no duration.

but when you create an event in calendar you need a beginning and an ending.

when itinerary ask for korganiser to add an event itinerary does not supply an ending

then by default in this case korganizer set the ending at "23 h 59 mn"

For this kind of confirmation mail itinerary must supply ending = beginning + 2 h.

"2 h" is realistic for a dinner. No ?

Oh, I see, this happens when adding it to the calendar, I can reproduce now. Yes, 2h when no end time is given makes sense, I'll fix that.

Git commit 7e0e66911e642a82b8807022926d24996479fc19 by Volker Krause.
Committed on 13/10/2019 at 10:47.
Pushed by vkrause into branch 'Applications/19.08'.

Better end time default for restaurant reservations without an end time

M  +1    -1    src/calendarhandler.cpp

https://commits.kde.org/kitinerary/7e0e66911e642a82b8807022926d24996479fc19

thanks

when you buy a journey of "OUIGO" type at www.ouigo.com or with "ouigo" app
you get 3 mails:

- the day of your purchase, an order confirmation mail with only day, hours and train

- some days after, a ticket mail with pdf printable ticket with day, hours, train, car, deck ("salle haute", "salle basse"), seat, qr code

- 3 or 4 days before departure, a reminding mail, with day, hours, train, car, deck, seat, a detailed description of the journey

Today kde itinerary takes care with only "order confirmation mail", the less informative one.

It would be better to take care of the ticket mail or the reminding mail because if I add an event in my calendar I would like the most informative event.

I join the 3 mails : confirmation, ticket, reminder.




SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0

ADDITIONAL INFORMATION

kde apps 19.12.1

thanks

Created attachment 125608 [details]
ouigo confirmation mail

Created attachment 125609 [details]
ouigo ticket mail

Created attachment 125610 [details]
ouigo reminding mail

Created attachment 126080 [details]
SNCF TER confirmation mail from site www.ter.sncf.com/nouvelle-aquitaine

SNCF TER confirmation mail for a journey bought at site www.ter.sncf.com/nouvelle-aquitaine

Created attachment 126101 [details]
SNCf mixed travel ouigo and inoui

My travel :

Bordeaux - Paris by OUIGO
Paris - Bordeaux by INOUI

if I add my travel in my calendar
then
for Paris - Bordeaux by INOUI

Car number, Place number, Deck (Salle) top or bottom are not recorded in the event.

Thanks

Git commit 4b58675a4694136ffca0ed6e2f88846d38f4d592 by Volker Krause.
Committed on 19/02/2020 at 17:46.
Pushed by vkrause into branch 'master'.

Add initial support for Ouigo tickets

M  +23   -1    src/extractors/sncf.js
M  +41   -10   src/extractors/sncf.json

https://commits.kde.org/kitinerary/4b58675a4694136ffca0ed6e2f88846d38f4d592

Git commit a092e5fc49c4058aafbfe52d1dad294f813954b4 by Volker Krause.
Committed on 27/02/2020 at 17:51.
Pushed by vkrause into branch 'master'.

Correctly distinguish between SNCF and Ouigo PNRs

In a mixed ticket, you can have two different PNRs, picking the wrong one
will later break merging with the Ouigo ticket.

Also, extract the passenger name while we are at it.

M  +15   -7    src/extractors/sncf.js

https://commits.kde.org/kitinerary/a092e5fc49c4058aafbfe52d1dad294f813954b4

Created attachment 129339 [details]
25/6/2020, Bordeaux<->Paris INOUI, no coach, deck, place

(In reply to Philippe ROUBACH from comment #30)
> Created attachment 126101 [details]
> SNCf mixed travel ouigo and inoui
> 
> My travel :
> 
> Bordeaux - Paris by OUIGO
> Paris - Bordeaux by INOUI
> 
> if I add my travel in my calendar
> then
> for Paris - Bordeaux by INOUI
> 
> Car number, Place number, Deck (Salle) top or bottom are not recorded in the
> event.
> 
> Thanks

Problem still there. see 25/6/2020, Bordeaux<->Paris INOUI, no coach, deck, place confirmation mail.

Kde apps 20.04.2
kde plasma 5.19.0
kde frameworks 5.71.0

Created attachment 129340 [details]
A new SNCF TER confirmation mail which kitinerary does not take care at all.

Git commit bc8b78d47829da0bec4facdff3bf1a740751e5ae by Volker Krause.
Committed on 17/06/2020 at 15:06.
Pushed by vkrause into branch 'release/20.04'.

Extract seat reservation information from Ouigo confirmations

M  +7    -0    src/extractors/sncf.js

https://invent.kde.org/pim/kitinerary/commit/bc8b78d47829da0bec4facdff3bf1a740751e5ae

Created attachment 130236 [details]
a new SNCF OUI confirmation mail that kitinerary does not take care

a new SNCF OUI confirmation mail that kitinerary does not take care

Created attachment 138115 [details]
a new SNCF ter confirmation by the app "SNCF" that kitinerary does not take care

Git commit 8148a47d53dacf47de80f5b4d603e2c68ae3f095 by Volker Krause.
Committed on 14/07/2021 at 15:18.
Pushed by vkrause into branch 'release/21.08'.

Handle SNCF TER booking confirmations
Related: bug 439055
FIXED-IN: 21.08.0

M  +21   -0    src/lib/scripts/sncf.js
M  +33   -13   src/lib/scripts/sncf.json

https://invent.kde.org/pim/kitinerary/commit/8148a47d53dacf47de80f5b4d603e2c68ae3f095

Created attachment 147005 [details]
a new confirmation mail from sncf connect that kitinerary does not take care.

Thank you! This one doesn't seem to have the complete plan in the email though, right? Ie. this is a retour ticket with each direction involving two TER trains, but only the departure time of the first leg is specified, all other times as well as the station on which to change trains are missing if I read this correctly?

Yes it is right. It is not a complete document.

But it is sufficient to create an event for the go and an event for the return. no ?

Right, it's probably not good enough for the app at this point, but for a calendar entry we should be able to work with the incomplete data as well.

Created attachment 149881 [details]
sncf connect tgv cpnfirmation mail

new sncf connect tgv confirmation mail

Created attachment 149883 [details]
sncf connect TER confirmation mail

new sncf connect TER confirmation mail

Git commit 73e4195dacae2665503b59a167514c4684ee0b2b by Volker Krause.
Committed on 22/06/2022 at 16:14.
Pushed by vkrause into branch 'master'.

Extend trigger pattern for connect.sncf emails

M  +6    -0    src/lib/scripts/sncf.json

https://invent.kde.org/pim/kitinerary/commit/73e4195dacae2665503b59a167514c4684ee0b2b