Bug 404400 - sources combobox on app page has only one radio button
Summary: sources combobox on app page has only one radio button
Status: VERIFIED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.15.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
: 404399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-02-15 16:21 UTC by Harald Sitter
Modified: 2019-03-18 14:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.3


Attachments
screenshotty (116.55 KB, image/png)
2019-02-15 16:21 UTC, Harald Sitter
Details
screenshot of how kate does it (24.56 KB, image/png)
2019-02-15 16:22 UTC, Harald Sitter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2019-02-15 16:21:26 UTC
Created attachment 118110 [details]
screenshotty

on the apps pages there is a way to select the source where one wants to install an app from. in the view of that combobox the currently selected delegate has a checked radio button... BUT the others do not have unchecked radio buttons

STEPS TO REPRODUCE
1. have multiple sources for an app
2. go to app page
3. click sources in top right corner

OBSERVED RESULT
only one radio button

EXPECTED RESULT
they all should have radio buttons and the selected one should be checked while the others are unchecked. this should then be in line with what other apps are doing in similar cases

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 5.15
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Harald Sitter 2019-02-15 16:22:15 UTC
Created attachment 118111 [details]
screenshot of how kate does it
Comment 2 Nate Graham 2019-02-18 22:03:36 UTC
Yep. That's how everyone else does it, and that's how it should be here too.
Comment 3 Aleix Pol 2019-02-25 15:20:34 UTC
That's not a second combo box, this is "package-available" icon looking like an empty checkbox: https://phabricator.kde.org/source/breeze-icons/browse/master/icons/emblems/16/package-available.svg
Comment 4 Aleix Pol 2019-02-25 15:21:28 UTC
Uh never mind, I see what you mean.
Comment 5 Aleix Pol 2019-02-25 15:24:28 UTC
Git commit 668e91785d6028019e3da08da9a46204f712611f by Aleix Pol.
Committed on 25/02/2019 at 15:21.
Pushed by apol into branch 'Plasma/5.15'.

Mark all radio buttons as such

M  +1    -0    discover/qml/ApplicationPage.qml

https://commits.kde.org/discover/668e91785d6028019e3da08da9a46204f712611f
Comment 6 Nate Graham 2019-03-18 14:12:59 UTC
*** Bug 404399 has been marked as a duplicate of this bug. ***