Bug 404389 - Labels blend into each other when names are long
Summary: Labels blend into each other when names are long
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kdeclarative
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.55.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-15 13:21 UTC by Filip Fila
Modified: 2019-02-15 19:00 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.56


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Fila 2019-02-15 13:21:47 UTC
SUMMARY
The newly appearing wallpaper name labels in 5.15 blend into each other when the names are too long (usually when using filenames). 

STEPS TO REPRODUCE
1. Use Plasma 5.15
2. Have a very long wallpaper name or filename. 

OBSERVED RESULT
https://i.ibb.co/8xDQ3Q0/Screenshot-20190215-141726.png

EXPECTED RESULT
No label blending; I'd suggest to keep the label width the same as the preview width.
Comment 1 Nate Graham 2019-02-15 15:55:57 UTC
This comes from KDeclarative which is a framework BTW. Nothing to do with Plasma 5.15.
Comment 2 Nate Graham 2019-02-15 19:00:43 UTC
Git commit 23942e5708316ab678d3c31ab9f2c44440294f88 by Nate Graham, on behalf of Filip Fila.
Committed on 15/02/2019 at 18:55.
Pushed by ngraham into branch 'master'.

[GridDelegate] Fix long labels blending into each other

Summary:
This patch anchors the GridDelegate's label width and height to the thumbnail, as opposed to the parent.
FIXED-IN: 5.56

Test Plan:
Before:
{F6617357}

After:
{F6617359}

Reviewers: #frameworks, ngraham, #vdg

Reviewed By: ngraham, #vdg

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19047

M  +2    -2    src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

https://commits.kde.org/kdeclarative/23942e5708316ab678d3c31ab9f2c44440294f88