Bug 404309 - No hand shaped cursor when I hover over "Vendor" links
Summary: No hand shaped cursor when I hover over "Vendor" links
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-13 22:44 UTC by Patrick Silva
Modified: 2019-02-19 09:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot (65.24 KB, image/png)
2019-02-13 22:44 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-02-13 22:44:29 UTC
Created attachment 118054 [details]
screenshot

STEPS TO REPRODUCE
1. open Discover while some update from distro repositories is available
2. click "Update" in the side bar
3. click on some update available
4. hover over "Vendor" link
5. click "More info" button to open the app description
6. hover over "Vendor" link in the app description page

OBSERVED RESULT
normal cursor is visible in the steps 4 and 6, see my screenshot

EXPECTED RESULT
hand shaped cursor appears in the steps 4 and 6

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.0
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1
Comment 1 Dan Leinir Turthra Jensen 2019-02-14 09:58:37 UTC
Hmm... It would seem some of the link locations do not use LinkButtons. That'll certainly need fixing, thank you for spotting this one :) If you come across others, do give us a poke and we'll get right on that!
Comment 2 Dan Leinir Turthra Jensen 2019-02-19 09:54:12 UTC
Git commit 917819ac26f320c9a8aaec2d871b54ceb978398d by Dan Leinir Turthra Jensen.
Committed on 19/02/2019 at 09:53.
Pushed by leinir into branch 'master'.

Add (and use) a LinkLabel component

The component, which is deliberately very simple. just adds the
functionality to Label of ensuring we have a hand cursor when
hovering over a link in the Label component. This is required
due to missing functionality in both Text and QCC2's Label
components, which have no mouse cursor changing abilities. There
is a Qt bug regarding the issue, mentioned in this new
component's code, but so far it looks unlikely to get a "real"
fix anytime soon, so, for less headachiness, this component
(which simply takes code we already had in one place and
applies it slightly more widely and generically)...
Differential Revision: https://phabricator.kde.org/D19118

M  +1    -9    discover/qml/ApplicationPage.qml
A  +36   -0    discover/qml/LinkLabel.qml     [License: BSD]
M  +1    -1    discover/qml/ReviewDelegate.qml
M  +1    -1    discover/qml/UpdatesPage.qml
M  +1    -0    discover/resources.qrc

https://commits.kde.org/discover/917819ac26f320c9a8aaec2d871b54ceb978398d