Created attachment 117927 [details] screenshot SUMMARY Every time I open konsole preferences, an unnecessary vertical scroll bar is present and "Enable all 'Don't ask again' messages" button is cut off. STEPS TO REPRODUCE 1. open konsole 2. click "Settings" menu, select "Configure Konsole..." OBSERVED RESULT An unnecessary vertical scroll bar is present and "Enable all 'Don't ask again' messages" button is cut off. See the screenshot. EXPECTED RESULT No scroll bar, "Enable all 'Don't ask again' messages" button is not cut off. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.14.90 KDE Frameworks Version: 5.54.0 Qt Version: 5.12.1
Yeah, this drives me crazy too. I think you were working on this, Mariusz?
I've started the configure dialog redesign today, so this bug will be fixed.
I can't wait to see!
Should be fixed with https://phabricator.kde.org/D20816, once that eventually lands!
Git commit a8ec9ad28adfca9cb64252b965c3da2d3f1a634b by Kurt Hindenburg, on behalf of Mariusz Glebocki. Committed on 15/06/2019 at 16:52. Pushed by hindenburg into branch 'D20816'. Configure Konsole dialog GUI redesign Summary: * Use custom dialog and configuraton classes, as counterparts from KF5 are bugged. The KF5 versions should be fixed and used here. * Create new KConfigDialog-like class and use it to show existing configuration pages. * Create KConfigDialogManager-like class for managing QButtonGroups. * Remove help button from configuration dialog. There is nothing about configuration dialog options in the help. * Profile Settings: * Use QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate. * Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in favorite/show column. * Change default profile item style - it now has italics font and "(default)" suffix. * Disable "Delete" button when default profile is selected * Use slightly extended QKeySequenceEditor. KKeySequenceWidget looks heavily out of place in a tree view. New editor supports some control keys: * Esc key cancels key capture. * Del/backspace removes shortcut. * Enter confirms shortcut immediately. * Tab/backtab commits currently edited shorcut and moves to next/previous shortcut. * Shortcuts for non visible profiles use disabled text color. * Note about visibility and shortcuts * Rename "File Location" to "Temporary Files" * Enable path selector only when "custom" is selected * Place paths directly in labels * Disable all tabbar settings except visibility when visibility is set to "Never" * Minor string changes. **Screenshots** {F6893460} {F6893461} {F6893462} {F6893463} FIXED-IN: 19.08.0 Reviewers: #konsole, #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, hindenburg, #vdg, konsole-devel, #konsole Tags: #konsole, #vdg Differential Revision: https://phabricator.kde.org/D20816 M +3 -2 src/CMakeLists.txt M +1 -1 src/EditProfileGeneralPage.ui M +24 -23 src/MainWindow.cpp A +165 -0 src/settings/ConfigurationDialog.cpp [License: GPL (v2+)] A +289 -0 src/settings/ConfigurationDialog.h [License: GPL (v2+)] D +0 -41 src/settings/FileLocationSettings.cpp D +0 -252 src/settings/FileLocationSettings.ui M +272 -235 src/settings/GeneralSettings.ui M +173 -142 src/settings/ProfileSettings.cpp M +21 -15 src/settings/ProfileSettings.h M +122 -90 src/settings/ProfileSettings.ui M +10 -0 src/settings/TabBarSettings.cpp M +533 -198 src/settings/TabBarSettings.ui A +55 -0 src/settings/TemporaryFilesSettings.cpp [License: GPL (v2/3)] R +4 -4 src/settings/TemporaryFilesSettings.h [from: src/settings/FileLocationSettings.h - 081% similarity] A +162 -0 src/settings/TemporaryFilesSettings.ui https://invent.kde.org/kde/konsole/commit/a8ec9ad28adfca9cb64252b965c3da2d3f1a634b
Git commit a8ec9ad28adfca9cb64252b965c3da2d3f1a634b by Kurt Hindenburg, on behalf of Mariusz Glebocki. Committed on 15/06/2019 at 16:52. Pushed by scmsync into branch 'D20816'. Configure Konsole dialog GUI redesign Summary: * Use custom dialog and configuraton classes, as counterparts from KF5 are bugged. The KF5 versions should be fixed and used here. * Create new KConfigDialog-like class and use it to show existing configuration pages. * Create KConfigDialogManager-like class for managing QButtonGroups. * Remove help button from configuration dialog. There is nothing about configuration dialog options in the help. * Profile Settings: * Use QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate. * Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in favorite/show column. * Change default profile item style - it now has italics font and "(default)" suffix. * Disable "Delete" button when default profile is selected * Use slightly extended QKeySequenceEditor. KKeySequenceWidget looks heavily out of place in a tree view. New editor supports some control keys: * Esc key cancels key capture. * Del/backspace removes shortcut. * Enter confirms shortcut immediately. * Tab/backtab commits currently edited shorcut and moves to next/previous shortcut. * Shortcuts for non visible profiles use disabled text color. * Note about visibility and shortcuts * Rename "File Location" to "Temporary Files" * Enable path selector only when "custom" is selected * Place paths directly in labels * Disable all tabbar settings except visibility when visibility is set to "Never" * Minor string changes. **Screenshots** {F6893460} {F6893461} {F6893462} {F6893463} FIXED-IN: 19.08.0 Reviewers: #konsole, #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, hindenburg, #vdg, konsole-devel, #konsole Tags: #konsole, #vdg Differential Revision: https://phabricator.kde.org/D20816 M +3 -2 src/CMakeLists.txt M +1 -1 src/EditProfileGeneralPage.ui M +24 -23 src/MainWindow.cpp A +165 -0 src/settings/ConfigurationDialog.cpp [License: GPL (v2+)] A +289 -0 src/settings/ConfigurationDialog.h [License: GPL (v2+)] D +0 -41 src/settings/FileLocationSettings.cpp D +0 -252 src/settings/FileLocationSettings.ui M +272 -235 src/settings/GeneralSettings.ui M +173 -142 src/settings/ProfileSettings.cpp M +21 -15 src/settings/ProfileSettings.h M +122 -90 src/settings/ProfileSettings.ui M +10 -0 src/settings/TabBarSettings.cpp M +533 -198 src/settings/TabBarSettings.ui A +55 -0 src/settings/TemporaryFilesSettings.cpp [License: GPL (v2/3)] R +4 -4 src/settings/TemporaryFilesSettings.h [from: src/settings/FileLocationSettings.h - 081% similarity] A +162 -0 src/settings/TemporaryFilesSettings.ui https://commits.kde.org/konsole/a8ec9ad28adfca9cb64252b965c3da2d3f1a634b