Bug 404073 - In "Save as" dialog file name is not completing when is present extension
Summary: In "Save as" dialog file name is not completing when is present extension
Status: REPORTED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: Open/save dialogs (show other bugs)
Version: 5.71.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2019-02-07 21:52 UTC by Piotr Mierzwinski
Modified: 2020-06-24 20:24 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Mierzwinski 2019-02-07 21:52:25 UTC
SUMMARY
I click "Save as" and will get proper dialog with highlighting name excluding extension. Great. I start typing, highlighted name disappear only left what I typed plus extension (by default ".png"). The issue is that, entered name is not completing, despite in this directory is present matching item.
Only when I remove whole string and will start typing, file name is completing.


STEPS TO REPRODUCE
1. Make any screenshot
2. Click "Save as"
3. Dialog suggests something like "Screenshot_DATE_TIME.png", but rename it with (for instance): "MyScreenshot_1.png" and click OK.
4. Make another screenshot
5. Click "Save as"
6. Dialog again suggests name like "Screenshot_DATE_TIME.png", where name excluding .png is highlighted, and start typing like this: "My"

OBSERVED RESULT
I field name there is present only "My.png".

EXPECTED RESULT
I field name should be present "MyScreenshot_1.png" with highlighted completed part. Just because such item is present in current directory.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: YES
(available in About System)
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.54
Qt Version: 5.12.1

ADDITIONAL INFORMATION
Qt 5.12.1 (built against 5.12.0)
The xcb windowing system
Comment 1 Méven Car 2020-05-24 07:51:44 UTC
This assumes you want to overwrite your file or at least base your file naming on existing files, which FileWidgets can't guess for the users.
So I believe the behavior is fine.

Clicking on the desired file in the view would give the result you expect.
Comment 2 Piotr Mierzwinski 2020-05-24 21:32:24 UTC
(In reply to Méven Car from comment #1)
> This assumes you want to overwrite your file or at least base your file
> naming on existing files, which FileWidgets can't guess for the users.
> So I believe the behavior is fine.

No. Otherwise also completing name without extension would meant that I want to overwrite existing name, because I can select name from a list of names already existing files, whereas I want only use part of this name.

I'm not sure, maybe I wasn't clear earlier. I meant that pup up list doesn't appear if I start typing in case if extension of file is present in field.


> Clicking on the desired file in the view would give the result you expect.
Yes. So why we have completing at all? We can click on file name on the list, ritght?

I would like to get suggestions of names just without take your hands off the keyboard. The same what I get if I start typing name when field is empty.
Comment 3 Méven Car 2020-05-25 07:45:49 UTC
I see, just to rephrase, what you suggest would be to have completion disregarding extension.

And make the example more detailed:

In your example, in folder you have 

MyScreenshot_1.png

You have Screenshot_DATE_TIME.png in the text field with Screenshot_DATE_TIME selected.
You type "My", field text is now My.png all text unselected with cursor before .png .

At this point you would like to have the completion popup with "MyScreenshot_1.png" offered.

So it's a feature request to have smarter completion when saving files.

>> Clicking on the desired file in the view would give the result you expect.
> Yes. So why we have completing at all?
Completion match works currently by comparing the beginning of file names.
Removing the extension works too (typing four times Suppr key for instance)

But given our behavior of pre-selecting text excluding extension your suggestion makes sense.

> We can click on file name on the list, ritght?
Of course.
Comment 4 Piotr Mierzwinski 2020-06-24 20:24:39 UTC
(In reply to Méven Car from comment #3)
> I see, just to rephrase, what you suggest would be to have completion
> disregarding extension.
> 
> And make the example more detailed:
> 
> In your example, in folder you have 
> 
> MyScreenshot_1.png
> 
> You have Screenshot_DATE_TIME.png in the text field with
> Screenshot_DATE_TIME selected.
> You type "My", field text is now My.png all text unselected with cursor
> before .png .
> 
> At this point you would like to have the completion popup with
> "MyScreenshot_1.png" offered.
> 
> So it's a feature request to have smarter completion when saving files.
Yes. I met such completion in some applications in Windows, so I thought would be nice to have it here in my favorite DE.

> >> Clicking on the desired file in the view would give the result you expect.
> > Yes. So why we have completing at all?
> Completion match works currently by comparing the beginning of file names.
> Removing the extension works too (typing four times Suppr key for instance)
> 
> But given our behavior of pre-selecting text excluding extension your
> suggestion makes sense.

Simple scenario. In spectacle I click in "Save as", get file save dialog, whereas file name is highlighted excluding extension I start typing, so name is removing and now even I enter begin of name as is present in other files in opened directory then nothing is completed. I need to remove extension to get completion. 
Having completed file name I can easy correct it and don't need neither to remove extension to get completion nor enter whole file name or even click.
This is obvious that completion of file name makes life easy in managing files.

> > We can click on file name on the list, ritght?
> Of course.

You can change it as feature request if this is possible here.