Bug 404070 - Icon glitch in updates list when selecting 'More information' while using widescreen view
Summary: Icon glitch in updates list when selecting 'More information' while using wid...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: 5.14.90
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-07 20:49 UTC by Øystein Steffensen-Alværvik
Modified: 2019-02-12 20:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.1


Attachments
Video of the glitch (3.12 MB, video/webm)
2019-02-07 20:49 UTC, Øystein Steffensen-Alværvik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Øystein Steffensen-Alværvik 2019-02-07 20:49:57 UTC
Created attachment 117916 [details]
Video of the glitch

SUMMARY
Icon glitch after selecting 'More information' in Updates – some icons are enlarged for some reason. See attached video.

STEPS TO REPRODUCE
1. Go to the Updates view (when you have available updates of course)
2. Select a package in the list.
3. Select the package's 'More information …' button.

OBSERVED RESULT
In the package list some icons are weirdly enlarged.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: Kubuntu 19.04
KDE Plasma Version: 5.14.90
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3
Kernel Version: 4.18.0-11-generic
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-4210U CPU @ 1.70GHz
Memory: 11,6 GiB


ADDITIONAL INFORMATION
Tested with Breeze normal and Breeze dark
Comment 1 Nate Graham 2019-02-07 21:07:27 UTC
Can confirm. Very odd.
Comment 2 Nate Graham 2019-02-12 20:46:41 UTC
Git commit 502b963bcc96e5e9abb257e2cc90d3fea2212996 by Nate Graham, on behalf of Jonah Brüchert.
Committed on 12/02/2019 at 20:44.
Pushed by ngraham into branch 'Plasma/5.15'.

UpdatesPage: Fix icon sizing on small screens

Summary:
On Small screens (e.g phones), not all list items have the same height, for example when a package has a long version string.
Since the width of the icon was previously copied from the height, this resulted in inconsistent icon sizes.

This patch sets the icon size to a constant value, which fixes the problem.

Test Plan: Icon sizes are consistent and still correctly sized

Reviewers: #discover_software_store

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18964

M  +2    -2    discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/502b963bcc96e5e9abb257e2cc90d3fea2212996