When I enable "Apply effects to inactive windows", unchecking "Use different colors for inactive selections" has no effect, as far as I can tell. What I would expect is that when unchecked, inactive selections/parts of active windows do not receive inactive colors.
Git commit 585cc994e6c5d03d276cd06e93dd808cf0efac92 by Kai Uwe Broulik. Committed on 08/02/2019 at 08:01. Pushed by broulik into branch 'Applications/18.12'. [DolphinView] Use correct color group Use the inactive color group when the window is inactive and update when window state changes. Differential Revision: https://phabricator.kde.org/D18811 M +6 -1 src/views/dolphinview.cpp https://commits.kde.org/dolphin/585cc994e6c5d03d276cd06e93dd808cf0efac92
The option is about "inactive windows" not "inactive parts of windows". QWidget-based apps mostly do it fine with a few exceptions whereas QtQuick-/Kirigami-based apps don't seem to honor this setting at all.
Thanks for the incredibly quick fix and explanation!
Moving to Kirigami for the remainder of the fix.
> The option is about "inactive windows" not "inactive parts of windows". Actually, widgets that show persistent selections (usually QAbstractItemView and derived) *do* use inactive colors when they don't have focus, even when their window is active. (At least with "Use different colors for inactive selections" checked; I guess that is supposed to control this behavior.) Note that thunderbird does this also.
Right. Perhaps reasons like these and the fact it's off by default is probably why it hasn't carried over to more modern toolkits. At a quick glance it looks as though Kirigami's theme is global, there's no per-window instance I could set inactive when it doesn't have focus. Not sure we can (or want to) invest resources into fixing this tbh.
(In reply to Kai Uwe Broulik from comment #6) > Right. Perhaps reasons like these and the fact it's off by default is > probably why it hasn't carried over to more modern toolkits. > > At a quick glance it looks as though Kirigami's theme is global, there's no > per-window instance I could set inactive when it doesn't have focus. Not > sure we can (or want to) invest resources into fixing this tbh. hmm, no, it's not global, there is one instance for every user of it, as it's an attached property. now, in qqc2-desktop-style most of the business is in a singleton to save memory, so indeed becomes a bit difficult. I'm quite hesitant it's something worth fixing tough.