Bug 403758 - Shift+Click-and-drag will move all the layers when using the "Move Tool" set to "Move current layer"
Summary: Shift+Click-and-drag will move all the layers when using the "Move Tool" set ...
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: Usability (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-30 07:21 UTC by mvowada
Modified: 2024-08-22 16:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
"Move Tool" current behaviour (4.2.0). I have put suggestions between parentheses. (85.28 KB, image/png)
2019-01-30 10:13 UTC, mvowada
Details
"Move Tool" current behaviour (4.2.0). I have put suggestions between parentheses. (Text file) (2.16 KB, text/plain)
2019-01-30 10:21 UTC, mvowada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mvowada 2019-01-30 07:21:18 UTC
SUMMARY
When using the "SHIFT" key constraint the "Move Tool" set to "Move current layer", will move all the layers.

STEPS TO REPRODUCE
1. "CTRL+N" (New)
1. add 2 layers + paint something on them
2. "T" (Move Tool)
3. "Tool Options > Selection Mode > Move current layer" checked
4. "SHIFT+Click-and-drag" over a painted area

OBSERVED RESULT
All the layers will move (apart from the default white layer which is limitless)

EXPECTED RESULT
Move just the current layer, along the X/Y axes.

SOFTWARE/OS VERSIONS
Krita 4.1.7-4.2.0 on Ubuntu 14.04

ADDITIONAL INFORMATION
On Krita 3.3.3 it works well, apparently.
Forum thread for reference: https://forum.kde.org/viewtopic.php?f=139&t=156896
Comment 1 Halla Rempt 2019-01-30 07:30:24 UTC
There is a difference between pressing shift, click and drag and click, pressing shift and drag:

click (selects the layer), shift, move: moves the layer constrained horizontal and vertical.
shift, click, move: moves all layers, constrained horizontal and vertical.

I've documented this in the manual. I'm not sure I would actually call this a bug...
Comment 2 David REVOY 2019-01-30 07:46:16 UTC
Thank you for reporting this one @mvowada.

Reproduced:
- 4.1.5appimage~kubuntu18.04
- 4.2~compiled-git

@boud, I also always thought it was a bug. Because to move the whole group/stack, the dedicated shortcut is Ctrl + Drag. Having this "Move All" feature also on Shift made me often do mistakes while moving things around. To move something along an axis; it feels more logic to me to press Shift first (constrain) then do the Move action; that's why I fall easily in this one. (Note: Vector objects already works this way: Shift can be pressed before or after moving to constrain).
Comment 3 Halla Rempt 2019-01-30 08:22:46 UTC
I'm just trying to guess what Dmitry meant when writing this part of the code. In the code, there's this comment:

// Ctrl+Right click toggles between moving current layer and moving layer w/ content

Which suggests that ctrl-drag isn't meant to switch to moving the group, but current layer and layer with content -- and that obviously doesn't work either. shift-click (instead of click-shift) does have a special meaning in the tool system, but it doesn't look like it actually does something special.
Comment 4 David REVOY 2019-01-30 08:36:43 UTC
@boud: You are right. Ctrl+Drag does something else and a bit special. It looks like it should move the layer(pixels) found under the cursor; but moves the whole group if the pixels belong to a layer inside a group (and the whole stack if the layer belong to the root). 

Ctrl probably needs a simplier behavior because it sounds probably more logic to pipe 'R' (pick layer/group under cursor) then 'T' move action; instead of having a Ctrl+Move that attempt to do everything. I'll ask other artist on IRC later today if they use this special Ctrl+Move.
Comment 5 mvowada 2019-01-30 10:13:09 UTC
Created attachment 117726 [details]
"Move Tool" current behaviour (4.2.0). I have put suggestions between parentheses.
Comment 6 mvowada 2019-01-30 10:21:21 UTC
Created attachment 117727 [details]
"Move Tool" current behaviour (4.2.0). I have put suggestions between parentheses. (Text file)
Comment 7 Ahab Greybeard 2019-01-30 10:47:15 UTC
re. Comment 2 and Comment 4:

Ctrl+Drag will move all the layer stack if there is a movable painted area under the cursor. If there is not a movable painted area under the cursor then only the currently selected layer is moved. (When 'Move current layer' is the Move mode).

An example of 'no movable painted area' would be transparency or a locked painted background layer.

This is another demonstration of the complicated 'subtlety' of the mode + modifier + move operations.
Comment 8 wolthera 2019-04-08 15:21:53 UTC
I guess I'll set this one to confirmed given people can reproduce.
Comment 9 Dmitry Kazakov 2024-08-22 16:39:18 UTC
Remove triaged keyword from CONFIRMED bugs