Bug 403709 - In search lists (and only search lists) rating indication on delegate and on app page aren't synchronized with actual reviews' ratings
Summary: In search lists (and only search lists) rating indication on delegate and on ...
Status: RESOLVED UPSTREAM
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.15.3
Platform: Neon Linux
: HI normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-28 19:36 UTC by Alexander Mentyu
Modified: 2019-07-05 16:11 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
No rating from review in kmag app (501.28 KB, image/png)
2019-01-28 19:36 UTC, Alexander Mentyu
Details
screen recording (1.31 MB, video/webm)
2019-03-18 16:10 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2019-01-28 19:36:00 UTC
Created attachment 117707 [details]
No rating from review in kmag app

STEPS TO REPRODUCE
1. Open 'Applications' page.
2. Open 'Accessibility' page.
3. Open for example gXNeur or kmag app page.

OBSERVED RESULT
'No ratings yet' text is displayed below app name - but there is rating in the review of the app.

EXPECTED RESULT
Rating from reviews is displayed below app name.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.2
Kernel Version: 4.15.0-42-generic
Comment 1 Nate Graham 2019-02-05 22:06:36 UTC
Confirmed, this drives me crazy.
Comment 2 Nate Graham 2019-03-17 14:00:02 UTC
Hmm, now with git master I actually can't reproduce this anymore! Let's close it and re-open if we see it again.
Comment 3 Patrick Silva 2019-03-18 15:50:42 UTC
This bug persists on neon dev unstable.
Comment 4 Nate Graham 2019-03-18 15:57:18 UTC
Really? I don't see it. Any chance you could attach a screen recording?
Comment 5 Patrick Silva 2019-03-18 16:10:55 UTC
Created attachment 118889 [details]
screen recording
Comment 6 Nate Graham 2019-03-18 16:55:55 UTC
Ah I see the problem. The ratings are synchronized on the Featured page and in the browse lists, but not in the search lists. I can confirm.
Comment 7 Patrick Silva 2019-03-18 17:18:24 UTC
Here the problem also occurs in the browse lists.
Both Geogebra and kmag apps are affected.
Comment 8 Aleix Pol 2019-05-10 12:09:14 UTC
Nate, are you sure it depends on the list?

To me it seems like the ratings page isn't being generated properly. See kmag isn't listed at all here:
https://odrs.gnome.org/1.0/reviews/api/ratings

I don't see how it could depend on the view or state of Discover.

I'll reach out to ODRS maintainer.
Comment 9 Aleix Pol 2019-05-10 12:13:15 UTC
For reference, this is the (one?) review we can't see as a rating:
https://odrs.gnome.org/admin/review/8220
Comment 10 Nate Graham 2019-05-12 21:22:59 UTC
Confirmed, I no longer see a difference between the ratings on search results pages vs other pages. Maybe I never did...

Should this stay open, or is it 100% ODRS's fault?
Comment 11 Aleix Pol 2019-07-05 16:11:35 UTC
https://gitlab.gnome.org/Infrastructure/odrs-web/blob/master/app_data/odrs/views_api.py#L498

This shows that in order to have ratings we need to have reviews.

Let's review what we care about! :)