Bug 403641 - Add hover and pressed states in list view's buttons
Summary: Add hover and pressed states in list view's buttons
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-26 21:55 UTC by matheus4551
Modified: 2019-02-11 16:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.56


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description matheus4551 2019-01-26 21:55:53 UTC
Unlike in other areas, buttons in list views doesn't show any visual feedback when interacted with. Adding hover and pressed states should aid this issue.
Comment 1 Nate Graham 2019-02-05 22:17:16 UTC
Huge +1.
Comment 2 Nate Graham 2019-02-10 19:06:53 UTC
Looks like the problem is that these buttons are basically custom-synthesized fake toolbuttons instead of real toolbuttons.

I'll see what I can do.
Comment 3 Nate Graham 2019-02-10 19:26:58 UTC
Wasn't as hard as I thought. Here's a patch: https://phabricator.kde.org/D18908
Comment 4 Nate Graham 2019-02-11 16:02:44 UTC
Git commit bdb5465181b6e03ff0141111d3da95791121e15d by Nate Graham.
Committed on 11/02/2019 at 16:02.
Pushed by ngraham into branch 'master'.

[SwipeListItem] Use a real toolbutton to improve usability

Summary:
Use a real toolbutton instead of a custom icon + mouse area, which
provides hovered and clicked states automatically and simplifies
the code a bit.
FIXED-IN: 5.56

Test Plan:
Hovered state: {F6605906, size=full}
Pressed state: {F6605907, size=full}

Reviewers: mart, #kirigami

Reviewed By: mart, #kirigami

Subscribers: apol, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D18908

M  +15   -23   src/controls/templates/SwipeListItem.qml

https://commits.kde.org/kirigami/bdb5465181b6e03ff0141111d3da95791121e15d