Bug 403599 - Append .paintingassistant extension by default
Summary: Append .paintingassistant extension by default
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Assistants (show other bugs)
Version: 4.1.7
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2019-01-25 20:44 UTC by beuc
Modified: 2019-04-08 19:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description beuc 2019-01-25 20:44:25 UTC
SUMMARY

STEPS TO REPRODUCE

When saving an assistant, I didn't know what extension to use.
I left it blank expecting Krita to fill in for me.

OBSERVED RESULT

Instead there was no extension ("test" input -> "test." file).

More importantly: when trying to open said assistant, Krita would filter the extensions to either "Krita Assistant", without letting me know what extension it was looking for, or "Support files", which filters "test." as well as other extensions I tried (e.g. ".assistant"). I had to copy/paste the exact filename to make Krita open it.

I eventually found the ".paintingassistant" extension by chance in a 3rd-party tutorial video.

EXPECTED RESULT

1. Krita fills in the .paintingassistant when saving an assistant
2. Krita offers the option to open any extension when loading an assistant
3. Krita mentions the .paintingassistant in the file type, e.g. "Krita Assistant (*.paintingassistant)", rather than just "Krita Assistant"

Incidentally
4. The file dialog title ("Save Assistant") is translated in French as "Assistant for Saving" rather than "Saving the Assistant" - not sure where to report this :)

SOFTWARE/OS VERSIONS
Krita 4.1 branch / GNU/Linux

ADDITIONAL INFORMATION

I looked in the code and saw that parts of Krita use QFileDialog (which could use setDefaultSuffix for this simple case), but this save dialog uses KoFileDialog - so I'm not sure how this should be fixed.
Comment 1 wolthera 2019-04-08 15:28:11 UTC
This only happens when there's a '.' at the end. When there isn't a '.' at the end, krita will append the extension...
Comment 2 beuc 2019-04-08 15:35:24 UTC
I believe you misread my report.
In 4.1.7 I typed "test" and it generated a "test." file.
Comment 3 wolthera 2019-04-08 18:38:15 UTC
That's bizare, that doesn't happen in master in my own tests...
Comment 4 beuc 2019-04-08 18:43:52 UTC
Maybe that's fixed in master, but in 4.1.7 (either recompiled or the one in Debian Buster) that is not :)
Comment 5 wolthera 2019-04-08 18:45:26 UTC
Well, we're not making any 4.1.x releases anymore, so then this other error needs to be fixed for 4.2 and then we can close it :)
Comment 6 Scott Petrovic 2019-04-08 19:48:42 UTC
I just tested this on master and it is fixed on Windows 10 too already. It probably got fixed in 4.2 at some point. I am going to close this ticket. Krita 4.2 should be coming out next month some time (or download the nightly build)

If there is still an issue for reason, this ticket can be re-opened, or a new one can be created.