Bug 403535 - Canvas isn't cleared when adding a new blank frame.
Summary: Canvas isn't cleared when adding a new blank frame.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 4.1.7
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Ashwin Dhakaita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-23 19:33 UTC by Jasper
Modified: 2019-02-08 08:51 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: krita 4.2.0-pre-alpha (git 0d8b6bd)
Sentry Crash Report:


Attachments
Quick demonstration of the bug (230.01 KB, video/mp4)
2019-01-23 19:33 UTC, Jasper
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jasper 2019-01-23 19:33:35 UTC
Created attachment 117624 [details]
Quick demonstration of the bug

SUMMARY
Canvas isn't cleared when creating a blank frame.

STEPS TO REPRODUCE
1. Set Krita's workspace to Animation.
2. Create a new document.
3. Create two new blank frames.
4. Draw on each frame a line.
5. Click on "Create Blank Frame" while having one of the two frames selected.
6. Draw a line across the other line.

7. Switch to the other frame and back.

OBSERVED RESULT
The old frame is still visible after creating a blank frame.

EXPECTED RESULT
The current canvas is cleared.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
I reprodused this bug on:
Windows 10 (OpenGL & DirectX), Krita 4.1.7
Manjaro Krita 4.1.7 & newest Krita (compiled from source)
Comment 1 mvowada 2019-01-23 21:21:44 UTC
Hi, I can easily reproduce this on Ubuntu 14.04 with Krita 4.2.0-pre-alpha (git 0c1da95). Thanks for the clear report and the video.
Comment 2 Dmitry Kazakov 2019-02-08 08:51:41 UTC
Git commit ab53dc16aaa9bfb2992d39325dcaa5e7fb83522d by Dmitry Kazakov, on behalf of Ashwin Dhakaita.
Committed on 08/02/2019 at 08:49.
Pushed by dkazakov into branch 'master'.

Fixed canvas isn't cleared when adding a new blank frame

Summary:
When create blank frame is clicked on animation docker having a  keyframe selected, that is not the last frame in the timeline, the canvas is not cleared properly.

Note from Dmitry Kazakov: setDirty() should be called **after** the
actual device change has been done. Otherwise race condition may happen.
FIXED-IN:    krita 4.2.0-pre-alpha (git 0d8b6bd)
Reviewers: #krita, dkazakov!
Subscribers: dkazakov
Tags: #krita
Differential Revision: https://phabricator.kde.org/D18790

M  +5    -0    plugins/dockers/animation/kis_animation_utils.cpp

https://commits.kde.org/krita/ab53dc16aaa9bfb2992d39325dcaa5e7fb83522d