Bug 403480 - Plasma-nm NetworkManager OpenConnect VPN: Login window is badly dimensioned by default
Summary: Plasma-nm NetworkManager OpenConnect VPN: Login window is badly dimensioned b...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Networks widget (show other bugs)
Version: master
Platform: Fedora RPMs Linux
: NOR major
Target Milestone: 1.0
Assignee: Jan Grulich
URL:
Keywords:
: 380399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-01-21 23:07 UTC by aderocha
Modified: 2024-12-23 18:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.4
Sentry Crash Report:


Attachments
Tar containing 3 images, 2 showing hidden buttons and 1 what should be a window properly dimensioned (184.31 KB, application/gzip)
2019-01-21 23:07 UTC, aderocha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description aderocha 2019-01-21 23:07:10 UTC
Created attachment 117606 [details]
Tar containing 3 images, 2 showing hidden buttons and 1 what should be a window properly dimensioned

SUMMARY
Plasma-nm NetworkManager OpenConnect VPN: Login window is badly dimensioned by default what causes some buttons to be hidden.

I consider this a major because is not easy to see that some buttons are hidden including the one that allows user to connect to the server and login.
When desktop language is set to english the connect button is partially visible but in other languages having longer sentences the button is completely hidden.

STEPS TO REPRODUCE
1. Select a openconnect VPN connection
2. Login window is shown
3.

OBSERVED RESULT
Login window is shown with connect button partially or completely hidden

EXPECTED RESULT
By default window should never be shown with hidden elements, independently of the Language used in the desktop.

User should not be able to shrink the window to a size that hides the window elements (like buttons, etc)

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Fedora 29
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.53.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION
NetworkManager -> 1:1.12.6-5.fc29
NetworkManager-openconnect -> 1.2.4-10.fc29
Comment 1 gvgeo 2020-02-12 14:48:35 UTC
*** Bug 380399 has been marked as a duplicate of this bug. ***
Comment 2 Joseph Yasi 2020-03-27 20:54:43 UTC
I've also noticed this. It's really annoying to have to resize the dialog everytime I connect to an openconnect VPN.

Note: I have a 4K 28" monitor. I don't know if the reason the buttons are hidden is because the dialog doesn't scale properly in hidpi, or if it is always hidden regardless of DPI.
Comment 3 Joseph Yasi 2020-03-27 20:58:41 UTC
I should note that I'm running Kubuntu 19.10 with the kubuntu backports PPA. The version of plasma-nm I currently have installed is 5.18.3.
Comment 4 Joseph Yasi 2020-03-27 21:05:44 UTC
It looks like this commit was committed to the Plasma/5.10 stable branch, but not to master or any future branches: https://commits.kde.org/plasma-nm/285c7ae37a3f6149b866dfb887bcb62ca6ce1046
Comment 5 Jan Grulich 2020-03-28 05:57:28 UTC
Git commit 42681b384d72c244b63bf81e03efc723a56f2a8b by Jan Grulich.
Committed on 28/03/2020 at 05:56.
Pushed by grulich into branch 'Plasma/5.18'.

Openconnect: make sure the UI fits into the password dialog
FIXED-IN: 5.18.4

M  +14   -4    vpn/openconnect/openconnectauth.ui

https://commits.kde.org/plasma-nm/42681b384d72c244b63bf81e03efc723a56f2a8b
Comment 6 Joseph Yasi 2020-04-04 14:58:20 UTC
I tried the commit that was submitted. It doesn't fix the issue. The window is still too narrow, and covers the connect button.
Comment 7 holgersson 2020-04-05 10:27:13 UTC
(In reply to Joseph Yasi from comment #6)
> I tried the commit that was submitted. It doesn't fix the issue. The window
> is still too narrow, and covers the connect button.

Hi, on my host it fixes the issue for HD on a 12.5" screen. Please test
with a updated plasma-5.18.4 to avoid some strange interactions between
different part of plasma - and of course restart your desktop after the
update.

If the bug isn't fixed on your host re-open it here or create a new bug with
more details of your setup and a reference to this this one.
Comment 8 Ben Cooksley 2024-12-23 18:25:51 UTC
Bulk transfer as requested in T17796