Bug 403403 - Comboboxes whose pop-ups contained images/pixmaps, rendered text previews can be only closed by clicking on the button itself
Summary: Comboboxes whose pop-ups contained images/pixmaps, rendered text previews ca...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-19 17:03 UTC by Matej Mrenica
Modified: 2019-02-07 15:07 UTC (History)
5 users (show)

See Also:
Latest Commit: https://commits.kde.org/qqc2-desktop-style/0ac99af6e6917051083cbf21c855a90ec4bd043d
Version Fixed In: 5.55
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2019-01-19 17:03:52 UTC 
... but not by clicking anywhere else. The same applies for 'Hinting' preview.

KDE Frameworks Version: 5.54
Qt Version: 5.12
Comment 1 Nate Graham 2019-01-20 02:23:16 UTC 
Whoa, that's weeeeird!
Comment 2 Nate Graham 2019-01-23 14:45:51 UTC 
The cursors KCM's combobox has the same issue. These are both QML KCMs; moving to qqc2-desktop-style
Comment 3 Patrick Silva 2019-01-23 14:51:55 UTC 
*** Bug 401282 has been marked as a duplicate of this bug. ***
Comment 4 David Edmundson 2019-01-23 17:02:18 UTC 
I don't think it has anything to do with the contents of the comobox.

Because QQC2 popups are inline. There's a QQuickOverlay across the rest of the window that detects mouse clicks. That doesn't seem to work on the KCM case because someone else is stealing the clicks.
Comment 5 David Edmundson 2019-01-29 16:42:30 UTC 
Git commit 0ac99af6e6917051083cbf21c855a90ec4bd043d by David Edmundson.
Committed on 29/01/2019 at 14:53.
Pushed by davidedmundson into branch 'master'.

Set combobox popups to be modal

Summary:
This closer matches what we see on QWidgets where losing focus closes
the combobox.

Test Plan:
Opened a combobox
Clicked outside
It closed

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18596

M  +1    -0    org.kde.desktop/ComboBox.qml

https://commits.kde.org/qqc2-desktop-style/0ac99af6e6917051083cbf21c855a90ec4bd043d
Comment 6 Patrick Silva 2019-02-06 19:32:50 UTC 
it's not completely fixed, dropdowns remain open depending on the area clicked.

open system settings > cursor
open "Size" dropdown
while the dropdown is still open, click aside "Apply" button on botton
"Size" dropdown remains open
Comment 7 Patrick Silva 2019-02-06 19:33:16 UTC 
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.0
Comment 8 Nate Graham 2019-02-07 14:56:47 UTC 
Interestingly, the click event does seem to trickle down; after the pop-up is closed, the button has been clicked. Can you open a new bug report for this? Thanks!
Comment 9 Patrick Silva 2019-02-07 15:07:03 UTC 
reported as bug 404060