Bug 403369 - Root icon is still the old one
Summary: Root icon is still the old one
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: 18.12.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-18 17:18 UTC by Matej Mrenica
Modified: 2019-01-20 01:52 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2019-01-18 17:18:02 UTC
Recently the icon for root folder was updated, but mine remained the same.

KDE Plasma Version: 5.14.90
KDE Frameworks Version: 5.54
Qt Version: 5.12

See screenshot: https://imgur.com/a/SCgLIJA
Comment 1 Matej Mrenica 2019-01-18 17:20:05 UTC
Also when you look at the screenshot, some words are translated and some are not (run with 'LANG=C'), why?
Comment 2 Matej Mrenica 2019-01-18 17:34:05 UTC
(In reply to mthw0 from comment #1)
> Also when you look at the screenshot, some words are translated and some are
> not (run with 'LANG=C'), why?

Ignore this one, I have renamed them manually.
Comment 3 Nate Graham 2019-01-18 20:42:48 UTC
Does the problem go away if you delete the icon cache with rm ~/.cache/icon-cache.kcache?
Comment 4 Viorel-Cătălin Răpițeanu 2019-01-18 22:02:53 UTC
I'm running the same setup, but I'm not seeing this issue. It might be a configuration issue (probably what Nate Graham suggested).
Comment 5 Matej Mrenica 2019-01-19 07:56:15 UTC
(In reply to Nate Graham from comment #3)
> Does the problem go away if you delete the icon cache with rm
> ~/.cache/icon-cache.kcache?

No it doesn't.
Comment 6 Antonio Rojas 2019-01-19 09:38:30 UTC
It you had a Root entry in your .local/share/user-places.xbel before the icon was updated, then the icon will not change in your local file (which overrides the upstream default).
Comment 7 Matej Mrenica 2019-01-19 12:09:15 UTC
(In reply to Antonio Rojas from comment #6)
> It you had a Root entry in your .local/share/user-places.xbel before the
> icon was updated, then the icon will not change in your local file (which
> overrides the upstream default).

So can I just delete the lines related to the root entry form the file?
Comment 8 Matej Mrenica 2019-01-19 12:21:40 UTC
(In reply to mthw0 from comment #7)
> (In reply to Antonio Rojas from comment #6)
> > It you had a Root entry in your .local/share/user-places.xbel before the
> > icon was updated, then the icon will not change in your local file (which
> > overrides the upstream default).
> 
> So can I just delete the lines related to the root entry form the file?

It looks like I can't, but deleting the file gives me the new icons in Places.

So this means that the new icons would only appear for people who did clean install after the change?
Shouldn't they have been changed for everyone on their own?
Comment 9 Nate Graham 2019-01-20 01:52:40 UTC
(In reply to mthw0 from comment #8)
> (In reply to mthw0 from comment #7)
> > (In reply to Antonio Rojas from comment #6)
> > > It you had a Root entry in your .local/share/user-places.xbel before the
> > > icon was updated, then the icon will not change in your local file (which
> > > overrides the upstream default).
> > 
> > So can I just delete the lines related to the root entry form the file?
> 
> It looks like I can't, but deleting the file gives me the new icons in
> Places.
> 
> So this means that the new icons would only appear for people who did clean
> install after the change?
> Shouldn't they have been changed for everyone on their own?

Ah, that's right. I forgot that we actually changed it to use a different icon rather than just updating the existing icon. So clearing the icon cache wouldn't have any effect in this case

There may be some value to figuring out how to change default places panel icons that haven't been explicitly overridden, but there's also an argument for not changing things out from under users. Might want to err on the side of not changing the icons of people's places panel items.