Bug 403368 - "Copy to Clipboard in English" sometimes shows up with non-American English locales
Summary: "Copy to Clipboard in English" sometimes shows up with non-American English l...
Status: RESOLVED FIXED
Alias: None
Product: kinfocenter
Classification: Applications
Component: KInfoCenter Viewer (show other bugs)
Version: 5.14.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Hubner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-18 17:17 UTC by Nate Graham
Modified: 2020-01-20 16:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments
Button shows up for en_GB (230.36 KB, image/png)
2019-01-18 17:17 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-01-18 17:17:53 UTC
Created attachment 117545 [details]
Button shows up for en_GB

Check out the screenshots on https://blog.neon.kde.org/index.php/2019/01/17/test-kde-plasma-5-15-beta-with-neon/ (attached here too for posterity)

In those screenshots, the system locale was ser to en_GB, but kinfocenter inappropriately displayed the "Copy to Clipboard in English" button (en_GB *is* English!).

I am not able to reproduce this locally, but it's clearly reproducible in some cases, as the screenshots prove.
Comment 1 Harald Sitter 2020-01-20 16:34:15 UTC
Git commit 87d793d15f606accc93fcef7d795800f35eb8857 by Harald Sitter.
Committed on 20/01/2020 at 16:33.
Pushed by sitter into branch 'Plasma/5.18'.

do not show "copy in english" when using C as locale

Summary:
qlocale differentiates LANG=C from LANG=en_US for us it is
though as the native untranslated strings are english, so when
kinfocenter is invoked with C it will effectively be == en_US.
with that in mind we don't need the copy in english button when
using C.
FIXED-IN: 5.18.0

Test Plan: LANG=C.UTF-8 no longer causes the button to be visible

Reviewers: mart, ngraham

Reviewed By: mart, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26792

M  +1    -1    Modules/about-distro/src/Module.cpp

https://commits.kde.org/kinfocenter/87d793d15f606accc93fcef7d795800f35eb8857