Bug 403357 - [Wayland] Virtual desktops listed under "Desktops" submenu of the window decoration are not highlighted on mouseover
Summary: [Wayland] Virtual desktops listed under "Desktops" submenu of the window deco...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: wayland-generic (show other bugs)
Version: 5.19.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-18 14:16 UTC by Patrick Silva
Modified: 2021-09-18 18:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-01-18 14:16:32 UTC
STEPS TO REPRODUCE
1. start Wayland session
2. enable and configure virtual desktops feature in "virtual desktops" kcm
3. open Dolphin, right click its window decoration, hover over "Desktops" submenu
4. hover over the virtual desktops listed 

OBSERVED RESULT
virtual desktops names are not highlighted on mouseover

EXPECTED RESULT
virtual desktops names should be highlighted on mouseover

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.14.90
KDE Frameworks Version: 5.54.0
Qt Version: 5.12.0


ADDITIONAL INFORMATION
I can't reproduce under X11.
Comment 1 Vlad Zahorodnii 2019-02-14 18:58:24 UTC
This also applies to activities menu as well.

Let me explain why desktop names are not highlighted. On Wayland we allow a window to be present on several virtual desktops. It would be not good (this is very subjective) to close the menu if a user selected only one out of several desired desktops.

Currently, there is no any sane way to prevent a QMenu from closing if one of checkable QActions was triggered. I'm aware of several ways to work around this issue:
* Put a QCheckBox into QWidgetAction;
* Re-implement some of QMenu's event handlers.

The latter approach would be PITA because there are many ways to check a checkable action and we would have to implement all of them.

So, we'd sticked with the former approach. Because checkboxes and menu items are styled differently, there is some inconsistency in "padding", highlighting, etc. But, on a brighter note, QMenu behaves as desired, at least that's something. :|

TLDR: It's complicated...
Comment 2 Patrick Silva 2021-09-18 18:00:08 UTC
Fixed on Plasma 5.23 beta. :)

Operating System: Arch Linux
KDE Plasma Version: 5.22.90
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Graphics Platform: Wayland