Bug 403356 - move the lock of the filter bar on the left close the close button
Summary: move the lock of the filter bar on the left close the close button
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: bars: filter (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks: 403379
  Show dependency treegraph
 
Reported: 2019-01-18 13:38 UTC by pier andre
Modified: 2019-05-26 03:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 19.08.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pier andre 2019-01-18 13:38:44 UTC
moving the lock button on the left of the bar could increase the usability becouse usually the bar is very long and one start to write on the left and to use the lock has to move to the end of the window on the right
Comment 1 Nate Graham 2019-01-18 20:51:42 UTC
Not a terrible idea.
Comment 2 Nate Graham 2019-05-13 01:55:32 UTC
Here's a patch: https://phabricator.kde.org/D21177
Comment 3 Nate Graham 2019-05-26 03:32:38 UTC
Git commit c22df71df28315b8b1964671d3452fad5b6ae0f5 by Nate Graham.
Committed on 26/05/2019 at 03:32.
Pushed by ngraham into branch 'master'.

When filter bar is focused, switch to view when tab key is pressed

Summary:
Various people have requested that the tab key move keyboard focus from the filter bar's
text edit field to the main view. It already does this when the Enter and return keys
are pressed, but apparently this is not very intuitive and people expect Tab to work too.

This patch makes that behavior possible by moving the Lock button to the left of the
text edit field, and re-arranging the code so that the filter bar is initialized first.
This works because Qt assigns tab ordering by default according to the order of widget
construction. So if we simply construct the main view right after the filter bar, then
the tab ordering is set up this way automatically.
Related: bug 403379
FIXED-IN: 19.08.0

Test Plan:
1. Activate Filter bar
2. Hit Tab key
3. View has become focused
4. Play around in Dolphin for a while and notice no regressions or crashes

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D21177

M  +14   -12   src/dolphinviewcontainer.cpp
M  +1    -1    src/filterbar/filterbar.cpp

https://commits.kde.org/dolphin/c22df71df28315b8b1964671d3452fad5b6ae0f5